Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config includes when any pattern has no match #95

Conversation

jkellerer
Copy link
Collaborator

Small bugfix for config includes, is a cherry-pick from #66

@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #95 (86eebc9) into master (83e423e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   62.19%   62.21%   +0.01%     
==========================================
  Files          63       63              
  Lines        5968     5971       +3     
==========================================
+ Hits         3712     3715       +3     
  Misses       2056     2056              
  Partials      200      200              
Impacted Files Coverage Δ
filesearch/filesearch.go 74.26% <100.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83e423e...86eebc9. Read the comment docs.

filesearch/filesearch.go Outdated Show resolved Hide resolved
filesearch/filesearch.go Outdated Show resolved Hide resolved
@jkellerer jkellerer force-pushed the fix-includes-with-no-match-pattern branch from 19727fd to 86eebc9 Compare February 27, 2022 16:23
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@creativeprojects
Copy link
Owner

LGTM!

Sunday fun... every time I type LGTM I think of this: https://www.youtube.com/watch?v=rR4n-0KYeKQ

@creativeprojects creativeprojects merged commit ad511c4 into creativeprojects:master Feb 27, 2022
@creativeprojects creativeprojects added this to the 0.17.0 milestone Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants