Skip to content

Commit

Permalink
Fix config includes when any pattern has no match
Browse files Browse the repository at this point in the history
  • Loading branch information
jkellerer committed Feb 27, 2022
1 parent 83e423e commit 19727fd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
4 changes: 4 additions & 0 deletions filesearch/filesearch.go
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ func FindConfigurationIncludes(configFile string, includes []string) ([]string,
addFile := func(file string) {
file = filepath.FromSlash(filepath.Clean(file))
if file != configFile {
clog.Tracef("include: %s", file)
files = append(files, file)
}
}
Expand All @@ -159,7 +160,10 @@ func FindConfigurationIncludes(configFile string, includes []string) ([]string,
for _, match := range matches {
addFile(match)
}
} else if err == nil {
clog.Tracef("no match: %s", include)
} else {
clog.Errorf("no match: %s ; %v", include, err)
return nil, err
}
}
Expand Down
1 change: 1 addition & 0 deletions filesearch/filesearch_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ func TestFindConfigurationIncludes(t *testing.T) {
{[]string{"*inc*." + testID + ".*"}, files[1:]},
{[]string{"inc1." + testID + ".conf"}, files[1:2]},
{[]string{"inc3." + testID + ".conf", "inc1." + testID + ".conf"}, []string{files[3], files[1]}},
{[]string{"inc3." + testID + ".conf", "no-match"}, []string{files[3]}},
// Does not include self
{[]string{"base." + testID + ".conf"}, []string{}},
{files[0:1], []string{}},
Expand Down

0 comments on commit 19727fd

Please sign in to comment.