Skip to content

Improve security checks in JSON parser and display translation #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chcmedeiros merged 3 commits into from
Jan 27, 2026
Merged

Improve security checks in JSON parser and display translation #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
028f1ee
Fixes out-of-bounds access in JSON parser
chcmedeiros Jan 27, 2026
cee070a
Fixes bounds check in translation function
chcmedeiros Jan 27, 2026
c7c5851
Grants write permissions for release creation
chcmedeiros Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,6 @@ jobs:
runs-on: ${{ github.repository_owner == 'zondax' && 'zondax-runners' || 'ubuntu-latest' }}
has-rust: false
has-nanos: false
node-version: '22'
node-version: '22'
permissions:
contents: write # Required for creating releases
12 changes: 6 additions & 6 deletions app/src/json/json_parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ parser_error_t array_get_element_count(const parsed_json_t *json,
}

*number_elements = 0;
if (array_token_index > json->numberOfTokens) {
if (array_token_index >= json->numberOfTokens) {
return parser_no_data;
}

Expand Down Expand Up @@ -128,7 +128,7 @@ parser_error_t array_get_nth_element(const parsed_json_t *json,
return parser_unexpected_value;
}

if (array_token_index > json->numberOfTokens) {
if (array_token_index >= json->numberOfTokens) {
return parser_no_data;
}

Expand Down Expand Up @@ -167,7 +167,7 @@ parser_error_t object_get_element_count(const parsed_json_t *json,
}

*element_count = 0;
if (object_token_index > json->numberOfTokens) {
if (object_token_index >= json->numberOfTokens) {
return parser_no_data;
}

Expand Down Expand Up @@ -203,7 +203,7 @@ parser_error_t object_get_nth_key(const parsed_json_t *json,
}

*token_index = object_token_index;
if (object_token_index > json->numberOfTokens) {
if (object_token_index >= json->numberOfTokens) {
return parser_no_data;
}

Expand Down Expand Up @@ -242,7 +242,7 @@ parser_error_t object_get_nth_value(const parsed_json_t *json,
return parser_unexpected_value;
}

if (object_token_index > json->numberOfTokens) {
if (object_token_index >= json->numberOfTokens) {
return parser_no_data;
}

Expand All @@ -260,7 +260,7 @@ parser_error_t object_get_value(const parsed_json_t *json,
return parser_unexpected_value;
}

if (object_token_index > json->numberOfTokens) {
if (object_token_index >= json->numberOfTokens) {
return parser_no_data;
}

Expand Down
2 changes: 1 addition & 1 deletion app/src/tx_display.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,7 @@ parser_error_t tx_display_translation(char *dst, uint16_t dstLen, char *src,
}

if (src[srcLen - 1] == ' ' || src[srcLen - 1] == '@') {
if (src[dstLen - 1] + 1 > dstLen) {
if (count >= dstLen) {
return parser_unexpected_value;
}
ASSERT_PTR_BOUNDS(count, dstLen);
Expand Down
Loading