Improve security checks in JSON parser and display translation #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects boundary checks in array and object access functions to prevent potential out-of-bounds reads when accessing JSON tokens. The condition `token_index > json->numberOfTokens` is replaced with `token_index >= json->numberOfTokens` to ensure that the last valid token can be accessed.
Corrects a bounds check in the translation function to prevent potential out-of-bounds access. The previous implementation was using the destination length incorrectly, leading to a faulty check. It now uses the current count, ensuring accurate validation.
Adds write permissions to the workflow for `contents`. This enables the workflow to create releases, which is required for automatically publishing new versions of the application.
abenso
approved these changes
Jan 27, 2026
chcmedeiros
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses security improvements identified in the JSON parser and text display translation functions.