Query Frontend: add new field for dense native histogram format #6199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
yeya24
force-pushed
the
add-histograms-raw
branch
from
f231dd8 to
a153624
Compare
Signed-off-by: Ben Ye <[email protected]>
yeya24
force-pushed
the
add-histograms-raw
branch
from
57472b1 to
4061437
Compare
|
@SungJin1212 Would you like to take a look? This PR tries to return dense native histogram format if it is protobuf codec with cortex internal set to true. Then you can continue the work in #6345 to implement everything end to end. Since there is no actual client asking for this format now I didn't add an integration test |
Signed-off-by: Ben Ye <[email protected]>
SungJin1212
reviewed
Dec 3, 2024
Signed-off-by: Ben Ye <[email protected]>
SungJin1212
approved these changes
Dec 3, 2024
|
LGTM! Thanks. |
SungJin1212
reviewed
Dec 3, 2024
Signed-off-by: Ben Ye <[email protected]>
yeya24
force-pushed
the
add-histograms-raw
branch
from
ddba207 to
f49e90e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
#6151 added support for Ruler to evaluate rules via sending gRPC requests to Query Frontend.
An issue we found out is that the current JSON format query response from Query Frontend doesn't allow Ruler to access the whole information of native histograms. As what Prometheus returns in its Query response is a more compact format of native histogram, not its full format.
With another in progress PR #5527, we can make it possible to return protobuf query response in Query Frontend through Querier. This could make it possible for Ruler to get the full representation of native histograms.
This PR adds a new
rawHistogramsfield to Query Frontend protobuf. This field should never be set when using JSON codec and should be only used when using Protobuf codec asked by Ruler.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]