Add --network-mode option

[rhjostone]

Addresses #665

Summary by Sourcery

New Features:

• Allow users to specify the network mode for containers.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces a new --network-mode option to the run subcommand, allowing users to configure the network mode of the container. By default, network access is disabled (none).

Sequence diagram for container setup with network mode

sequenceDiagram
    participant User
    participant CLI
    participant Model
    participant Container

    User->>CLI: run command with --network-mode
    CLI->>Model: setup_container(args)
    Note over Model: Check if subcommand is 'run'
    Model->>Model: Add network mode to container args
    Model->>Container: Create container with network settings
    Container-->>User: Container running with specified network mode

Loading

Class diagram showing CLI argument changes

classDiagram
    class ArgumentParser {
        +add_argument()
    }
    class RunParser {
        +ARGS: list
        +network_mode: str
    }
    class Model {
        +setup_container(args)
    }
    RunParser --|> ArgumentParser
    Model ..> RunParser: uses
    note for RunParser "Added --network-mode argument"
    note for Model "Modified to handle network mode"

Loading

File-Level Changes

Change	Details	Files
Added a --network-mode argument to the run subcommand.	Added a new argument --network-mode to the run subcommand. The default value for --network-mode is set to none. The help text for --network-mode explains its purpose and links to the podman documentation.	ramalama/cli.py
Implemented the --network-mode argument in the container setup.	Added the --network argument to the conman_args list when the subcommand is run. The value of the --network argument is set to the value of the --network-mode argument.	ramalama/model.py

Possibly linked issues

• Feature request: Add option to disable network access #665: The PR addresses the issue by adding a --network-mode option, which defaults to "none". This fulfills the request to disable network access by default.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @rhjostone - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[rhatdan]

This option should be available for run and serve. Basically for any container operation.

[dougsland]

I am assuming this is related to --network=host and --network=private?

[rhjostone]

I am assuming this is related to --network=host and --network=private?

Yeah, this should let you set any network driver that's supported in podman/docker:

https://docs.podman.io/en/latest/markdown/podman-run.1.html#network-mode-net
https://docs.docker.com/engine/network/#drivers

[rhatdan]

Thanks @rhjostone this is very good.

Please squash your commits.

git rebase -i origin
git push --force

[rhjostone]

Thanks @rhjostone this is very good.

Please squash your commits.

git rebase -i origin git push --force

Done!

[rhatdan]

LGTM

[dougsland]

alright, lets do it. LGTM Thanks for checking @rhjostone

[rhjostone]

Thanks @dougsland @rhatdan!

[rhatdan]

Test wants the options to be alphabetically sorted in the man pages.

[rhjostone]

@rhatdan Does the ordering in the man pages look correct now?

[dougsland]

CI/CD not related to this change. Personally, I would love to have a documentation explaining the options and showing what happens if you change from one option to another. However, can be in a different patch.

[dougsland]

As he fixed the last milestone as @rhatdan requested and the patch looks good, moving forward. Thanks @rhjostone

[ericcurtin]

This PR should have not been merged @dougsland it didn't pass a single bats build

[ericcurtin]

Opening a revert PR.

@rhjostone after the revert is complete, could you push this PR again? We need to then fix the tests so we can merge it when it's green.

A lot of people are opening PRs right now and they are gonna fail unless we revert.

[dougsland]

Opening a revert PR.

@rhjostone after the revert is complete, could you push this PR again? We need to then fix the tests so we can merge it when it's green.

A lot of people are opening PRs right now and they are gonna fail unless we revert.

Could you please share the error @ericcurtin ? To me the CI/CD is already broken for ages.

[rhatdan]

This PR is reverted.

[ericcurtin]

Opening a revert PR.
@rhjostone after the revert is complete, could you push this PR again? We need to then fix the tests so we can merge it when it's green.
A lot of people are opening PRs right now and they are gonna fail unless we revert.

Could you please share the error @ericcurtin ? To me the CI/CD is already broken for ages.

The error is in the CI logs in this PR.

@rhjostone can you re-push this PR, work through the tests to get them passing please.

[rhjostone]

@ericcurtin It looks like the PR was reverted, then re-merged thanks to @rhatdan:

760b6fd

Do I still have to re-push the PR?

[rhatdan]

No, I took care of it. Thanks alot @rhjostone

[rhjostone]

Good to know, thanks!