Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add option to disable network access #665

Closed
joshua-stone opened this issue Jan 30, 2025 · 4 comments
Closed

Feature request: Add option to disable network access #665

joshua-stone opened this issue Jan 30, 2025 · 4 comments

Comments

@joshua-stone
Copy link

There doesn't appear to be a way to pass --network=none for limiting network access:

def setup_container(self, args):

I believe that having a straightforward way to confine locally-running AI models would be useful for guaranteeing privacy and security in general.

@rhatdan
Copy link
Member

rhatdan commented Jan 30, 2025

I think it makes sense to default to --network=none, to help alleviate fears from people using random AI Models (deepseek for example).

Care to open a PR?

@rhjostone
Copy link
Contributor

@rhatdan Should I make this a global option for subcommands like serve, or should it be made exclusive for run for now since serve implicitly requires network access anyway?

#674

@rhatdan
Copy link
Member

rhatdan commented Jan 30, 2025

Anything that runs a container should have this.

run, serve, convert, and push off the top of my head.

@rhatdan
Copy link
Member

rhatdan commented Feb 3, 2025

--network=mode is merged.

@rhatdan rhatdan closed this as completed Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants