State export import #348
Merged
State export import #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #348 +/- ##
==========================================
+ Coverage 56.92% 57.57% +0.64%
==========================================
Files 73 73
Lines 5205 5440 +235
==========================================
+ Hits 2963 3132 +169
- Misses 1954 1996 +42
- Partials 288 312 +24
|
ethanfrey
approved these changes
Apr 28, 2022
because sanity checks have been removed.
alpe
force-pushed
the
340-state_export_import
branch
from
5cd1ff5 to
a2d530d
Compare
PoE genesis restructuring
maurolacy
approved these changes
May 4, 2022
| repeated cosmwasm.wasm.v1.Model models = 1 [ (gogoproto.nullable) = false ]; | ||
| } | ||
|
|
||
| // CustomModel contains the raw json data for a contract to seed it's state on |
There was a problem hiding this comment.
Suggested change
| // CustomModel contains the raw json data for a contract to seed it's state on | |
| // CustomModel contains the raw json data for a contract to seed its state on |
| return nil | ||
| } | ||
| } | ||
| newCursor, err := v.doPageableQuery(ctx, ValsetQuery{ListActiveValidators: &ListValidatorsQuery{StartAfter: cursor.String()}}, &rsp) |
There was a problem hiding this comment.
This is correct AFAIK. It's a little tricky with the pagination cursor, but this code is similar / equivalent to the one in TestListAllValidatorsViaCursor integration test (it just uses the doPageableQuery wrapper).
The cursor is a just copy of a field of the last element of the page (the operator address).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the #340 spike and #344
This design comes with a new
state_exporter_importerprivilege that allow contracts to register for a custom in state export/import callback.Design choices
No support for:
Reviewer
Genesis changes #351 are included in this branch, now
A good start would be to follow the code in:
Please do Squash + Merge. The single commits do not add value in the history
Follow up tasks
#356
#357
Testing
State export import can be manually tested via: