Spike: contract state export/import [continue] #344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because sanity checks have been removed.
alpe
reviewed
Apr 25, 2022
| @@ -129,12 +131,27 @@ func ExportGenesis(ctx sdk.Context, keeper *Keeper) *types.GenesisState { | |||
| contracts[i].ContractState = &types.Contract_CustomModel{CustomModel: &types.CustomModel{Msg: got}} | |||
| } | |||
|
|
|||
| var privileged []string | |||
There was a problem hiding this comment.
"pinned" code and "privileged" contract meta data are also stored in the CodeInfo and ContractDetails.
After thinking about this a bit more, we should not fill the pinned/privileged field here in export. This would duplicate the information and may cause issues when humans modify them for existing codes/ contracts.
In "seed" mode we don't have these fields explicitly set in the genesis for PoE contracts. They can be used though for other codes/ contracts that are not pinned/ privileged yet. Maybe some better naming can help?
| return false | ||
| }) | ||
|
|
||
| var pinned []uint64 |
There was a problem hiding this comment.
same as privileged: don't export here
| Contracts: contracts, | ||
| Sequences: wasmState.Sequences, | ||
| GenMsgs: wasmState.GenMsgs, | ||
| PrivilegedContractAddresses: privileged, |
| Sequences: wasmState.Sequences, | ||
| GenMsgs: wasmState.GenMsgs, | ||
| PrivilegedContractAddresses: privileged, | ||
| PinnedCodeIDs: pinned, |
| }), | ||
| wasmvm: noopMock, | ||
| expErr: true, | ||
| }, |
Merged
|
Closing this in favour of #348 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.