Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmaes: Add 0.10.0 #24202
base: master
Are you sure you want to change the base?
cmaes: Add 0.10.0 #24202
Changes from all commits
80515f3
a29853a
0198bb0
ab5c602
79f3dda
91724e6
bb9710d
70c7b7b
62b1cea
e45bbab
a8f1be6
2c1c3ab
aef42b4
7f4c46b
6dd4404
cff6a8b
1cc89e8
171eccc
d27837b
95a1ca6
6ca7bc7
4f7ea35
87239b4
209d577
1fa1468
2b34d0f
eb34bdc
b102d9e
ebc0e0b
743b8bb
a0ba9f0
d18682c
ef722e3
9583a7d
33f1c38
f323bcb
025c68d
499f8fb
1434ba5
6d1b59b
b3bee09
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this comes from CMA-ES/libcmaes#234, do you have any insight into wether it will be merged eventually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope so. I will trigger @beniz again. If there is a new version with the PR, then I can adjust the conanfile here to not include this patch for the new version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this change referenced anywhere in the logs/upstream. Is this an issue on the library itself? If this is a backport, it'd be great to separate it to its own patch, so that we can crossreference back to it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is removed in the current eigen master branch https://gitlab.com/libeigen/eigen/-/merge_requests/946
I also got some problems because this additonally defines an empty copy ctr and we needed it to copy the members
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could probably simplify this test_package, the less actual computation, the better and the more probable it is for the test package to stay valid for future versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could remove the first test and just use the second test with the commented lines removed. Would that be ok?