cmaes: Add 0.10.0 #24202

phbasler · 2024-06-03T05:53:47Z

Specify library name and version: cmaes/0.10.0

Add new package cmaes according to issue #24201
Fixes #24201

I am not the author of cmaes, but according to the authors in CMA-ES/libcmaes#233 I can provide this recipe.

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

… reviewers

* Protobug mutator compatible with Conan 2.x Signed-off-by: Uilian Ries <[email protected]> * Add version 1.3 Signed-off-by: Uilian Ries <[email protected]> * Enforce protobuf link Signed-off-by: Uilian Ries <[email protected]> * update abseil usage Signed-off-by: Uilian Ries <[email protected]> * consume all libs in tests Signed-off-by: Uilian Ries <[email protected]> * define cxx language in cmakelists Signed-off-by: Uilian Ries <[email protected]> * static-library on Windows Signed-off-by: Uilian Ries <[email protected]> * Exclude examples from CMakeLists.txt The upstream uses EXCLUDE_FROM_ALL CMake feature to avoid building examples by default, however, CMake still parses the example cmake file and requires more external dependencies like expat. Signed-off-by: Uilian Ries <[email protected]> * Do not build shared on Windows Signed-off-by: Uilian Ries <[email protected]> --------- Signed-off-by: Uilian Ries <[email protected]>

…GCC 14

Signed-off-by: Uilian Ries <[email protected]>

CLAassistant · 2024-06-03T05:53:53Z

All committers have signed the CLA.

uilianries · 2024-06-03T07:29:44Z

@phbasler Thank you for your PR! Please, take a look in you emails/accounts used in this PR: #24202 (comment)

The CLA bot listed 2 emails and it will not approve if both agrees to the CLA.

phbasler · 2024-06-03T07:35:49Z

@uilianries
Thanks.
The first commit was signed with an old e-mail adress which is not valid any longer.
I will have a look at it on how to change the assigned e-mail adress. Otherwise I will just redo the PR with the correct e-mail

…nter-index into packages/cmaes

recipes/cmaes/all/test_package/CMakeLists.txt

…nter-index into packages/cmaes

conan-center-bot · 2024-07-26T05:34:54Z

Conan v1 pipeline ✔️

All green in build 29 (1434ba5995303bf9f13c109c6553277451cc2830):

cmaes/0.10.0:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 29 (1434ba5995303bf9f13c109c6553277451cc2830):

cmaes/0.10.0:
All packages built successfully! (All logs)

phbasler · 2024-11-22T11:55:21Z

@AbrilRBS why did you remove the openmp option? Should the package not be used anymore?

AbrilRBS

Hi! Thanks for taking the time to create the PR, sorry that we didn't get back to you on a timely manner. I've left some comments on the PR, and made a cleanup now that Conan 1 support is no longer needed :)

recipes/cmaes/all/conanfile.py

AbrilRBS · 2024-11-22T11:52:36Z

recipes/cmaes/all/patches/CompilerOptionsEigen.patch

+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 4a38212..dccfea4 100644
+--- a/CMakeLists.txt
+++ b/CMakeLists.txt


I see this comes from CMA-ES/libcmaes#234, do you have any insight into wether it will be merged eventually?

I hope so. I will trigger @beniz again. If there is a new version with the PR, then I can adjust the conanfile here to not include this patch for the new version

AbrilRBS · 2024-11-22T11:53:22Z

recipes/cmaes/all/patches/CompilerOptionsEigen.patch

+ 	mutable std::normal_distribution<Scalar> norm; // gaussian combinator
+
+-	EIGEN_EMPTY_STRUCT_CTOR(scalar_normal_dist_op)
+	scalar_normal_dist_op() = default;


I don't see this change referenced anywhere in the logs/upstream. Is this an issue on the library itself? If this is a backport, it'd be great to separate it to its own patch, so that we can crossreference back to it

This is removed in the current eigen master branch https://gitlab.com/libeigen/eigen/-/merge_requests/946

I also got some problems because this additonally defines an empty copy ctr and we needed it to copy the members

AbrilRBS · 2024-11-22T11:54:06Z

recipes/cmaes/all/test_package/src/example.cpp

+
+int main()
+{
+  test1();


We could probably simplify this test_package, the less actual computation, the better and the more probable it is for the test package to stay valid for future versions

I could remove the first test and just use the second test with the commented lines removed. Would that be ok?

AbrilRBS · 2024-11-22T12:37:55Z

@AbrilRBS why did you remove the openmp option? Should the package not be used anymore?

Not that is should not be used per-se, it's more that its funcionality currently does not align with our expectations on CCI

ericLemanissier and others added 7 commits May 30, 2024 16:21

(conan-io#24165) remove ericLemanissier from the authorized_users and…

80515f3

… reviewers

(conan-io#24060) elfutils: Bump gettext to version 0.22.5 to support …

0198bb0

…GCC 14

(conan-io#24176) [sioclient] Build static libraries in Windows

ab5c602

Signed-off-by: Uilian Ries <[email protected]>

(conan-io#24174) meson: add version 1.4.1

79f3dda

(conan-io#24175) ada: add version 2.8.0

91724e6

(conan-io#24057) add extra-cmake-modules 6.2.0

bb9710d

conan-center-bot added the User-approval pending label Jun 3, 2024

This comment has been minimized.

Sign in to view

phbasler added 3 commits June 3, 2024 21:45

add cmaes

70c7b7b

Update config.yml

62b1cea

Remove trailing whitespace

e45bbab

phbasler force-pushed the packages/cmaes branch from 4baf1b5 to e45bbab Compare June 3, 2024 19:46

Merge branch 'master' into packages/cmaes

a8f1be6

conan-center-bot added Failed and removed User-approval pending labels Jun 3, 2024

This comment has been minimized.

Sign in to view

phbasler added 3 commits June 3, 2024 21:49

Apply linter comments

2c1c3ab

Merge branch 'packages/cmaes' of https://github.com/phbasler/conan-ce…

aef42b4

…nter-index into packages/cmaes

undo copy paste error

7f4c46b

This comment has been minimized.

Sign in to view

phbasler added 4 commits June 3, 2024 21:53

Remove unused imports

6dd4404

change name

cff6a8b

add line break

1cc89e8

Set layout src_folder arg

171eccc

Add empty new line at the end

d18682c

This comment has been minimized.

Sign in to view

Set c++ standard to 11 in test_package

ef722e3

phbasler commented Jul 15, 2024

View reviewed changes

recipes/cmaes/all/test_package/CMakeLists.txt Show resolved Hide resolved

conan-center-bot removed the Failed label Jul 15, 2024

This comment has been minimized.

Sign in to view

AbrilRBS self-assigned this Jul 15, 2024

phbasler added 2 commits July 17, 2024 07:22

Add second example and validate profile to have at least c++11

9583a7d

Merge branch 'packages/cmaes' of https://github.com/phbasler/conan-ce…

33f1c38

…nter-index into packages/cmaes

This comment has been minimized.

Sign in to view

Apply openmp settings from conan-io#24577

f323bcb

conan-center-bot added the Service Under Maintenance label Jul 22, 2024

This comment has been minimized.

Sign in to view

conan-center-bot added Failed and removed Service Under Maintenance labels Jul 24, 2024

This comment has been minimized.

Sign in to view

Add eigen to requires array

025c68d

This comment has been minimized.

Sign in to view

Add is_msvc to imports

499f8fb

This comment has been minimized.

Sign in to view

Undo openmp suggestions

1434ba5

conan-center-bot removed the Failed label Jul 26, 2024

conan-center-bot requested a review from AbrilRBS August 5, 2024 11:39

conan-center-bot requested a review from danimtb September 19, 2024 11:39

phbasler and others added 2 commits November 15, 2024 20:32

Merge branch 'conan-io:master' into packages/cmaes

6d1b59b

Cleanup

b3bee09

AbrilRBS reviewed Nov 22, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmaes: Add 0.10.0 #24202

cmaes: Add 0.10.0 #24202

phbasler commented Jun 3, 2024 •

edited

Loading

CLAassistant commented Jun 3, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

uilianries commented Jun 3, 2024

phbasler commented Jun 3, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Jul 26, 2024

phbasler commented Nov 22, 2024

AbrilRBS left a comment •

edited

Loading

AbrilRBS Nov 22, 2024

phbasler Nov 24, 2024

AbrilRBS Nov 22, 2024

phbasler Nov 24, 2024

AbrilRBS Nov 22, 2024

phbasler Nov 24, 2024

AbrilRBS commented Nov 22, 2024 •

edited

Loading

cmaes: Add 0.10.0 #24202

Are you sure you want to change the base?

cmaes: Add 0.10.0 #24202

Conversation

phbasler commented Jun 3, 2024 • edited Loading

CLAassistant commented Jun 3, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

uilianries commented Jun 3, 2024

phbasler commented Jun 3, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Jul 26, 2024

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

phbasler commented Nov 22, 2024

AbrilRBS left a comment • edited Loading

Choose a reason for hiding this comment

AbrilRBS Nov 22, 2024

Choose a reason for hiding this comment

phbasler Nov 24, 2024

Choose a reason for hiding this comment

AbrilRBS Nov 22, 2024

Choose a reason for hiding this comment

phbasler Nov 24, 2024

Choose a reason for hiding this comment

AbrilRBS Nov 22, 2024

Choose a reason for hiding this comment

phbasler Nov 24, 2024

Choose a reason for hiding this comment

AbrilRBS commented Nov 22, 2024 • edited Loading

phbasler commented Jun 3, 2024 •

edited

Loading

CLAassistant commented Jun 3, 2024 •

edited

Loading

AbrilRBS left a comment •

edited

Loading

AbrilRBS commented Nov 22, 2024 •

edited

Loading