Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F pending balance #42

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

F pending balance #42

wants to merge 13 commits into from

Conversation

aminlatifi
Copy link

Implemented pending balance feature

  • Migrate from Buidler to HardHat

Copy link

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MerlinEgalite
Copy link

MerlinEgalite commented May 16, 2021

addPendingBalances, setPendingBalances and registerContributors can be out of gas it too many contributors are added.
Also I am not sure if _cnt parameter is necessary as we compare the length of the first list with the second.

Copy link

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite the same comments sorry

contracts/registry/Registry.sol Show resolved Hide resolved
contracts/registry/Registry.sol Outdated Show resolved Hide resolved
contracts/registry/Registry.sol Outdated Show resolved Hide resolved
contracts/registry/Registry.sol Outdated Show resolved Hide resolved
contracts/registry/Registry.sol Show resolved Hide resolved
@kristoferlund
Copy link

addPendingBalances, setPendingBalances and registerContributors can be out of gas it too many contributors are added.
Also I am not sure if _cnt parameter is necessary as we compare the length of the first list with the second.

@MerlinEgalite Do you propose any change? Do the above functions need to be changed to avoid out-of-gas? Or do we just have to be careful not to add too many users at once?

@MerlinEgalite
Copy link

MerlinEgalite commented May 18, 2021

@kristoferlund this is not issue here if it reverts so we can keep it like this and just be careful to not exceed the max amount of gas.
For the _cnt it's up to @aminlatifi as it's not a blocker.

@aminlatifi
Copy link
Author

@kristoferlund this is not issue here if it reverts so we can keep it like this and just be careful to not exceed the max amount of gas.
For the _cnt it's up to @aminlatifi as it's not a blocker.

_cnt logic is legacy and I didn't change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants