-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F pending balance #42
base: master
Are you sure you want to change the base?
Conversation
Tests are added for registry smart contract
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Added pending balance to contributor info
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are quite the same comments sorry
@MerlinEgalite Do you propose any change? Do the above functions need to be changed to avoid out-of-gas? Or do we just have to be careful not to add too many users at once? |
@kristoferlund this is not issue here if it reverts so we can keep it like this and just be careful to not exceed the max amount of gas. |
_cnt logic is legacy and I didn't change it. |
Implemented pending balance feature