Skip to content

Commit

Permalink
Checking user existence is done by accounts set
Browse files Browse the repository at this point in the history
  • Loading branch information
aminlatifi committed May 18, 2021
1 parent 2f8d497 commit f9d68d9
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions contracts/registry/Registry.sol
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,10 @@ contract Registry is Context, AdminRole {
) external onlyAdmin {
require(_adrs.length == _cnt, "Invalid number of addresses");
require(_trusts.length == _cnt, "Invalid number of trust values");
require(_pendingBalances.length == _cnt, "Invalid number of pending balance values");
require(
_pendingBalances.length == _cnt,
"Invalid number of pending balance values"
);

for (uint256 i = 0; i < _cnt; i++) {
_register(_adrs[i], _trusts[i], _pendingBalances[i]);
Expand Down Expand Up @@ -285,7 +288,7 @@ contract Registry is Context, AdminRole {

function _remove(address _adr) internal {
require(_adr != address(0), "Cannot remove zero address");

This comment has been minimized.

Copy link
@MerlinEgalite

MerlinEgalite May 18, 2021

This line can be removed too as address(0) cannot be added

require(maxTrusts[_adr] != 0, "Address is not a contributor");
require(EnumerableSet.contains(accounts, _adr), "Address is not a contributor");

EnumerableSet.remove(accounts, _adr);
delete maxTrusts[_adr];
Expand All @@ -301,7 +304,7 @@ contract Registry is Context, AdminRole {
_adr != address(0),

This comment has been minimized.

Copy link
@MerlinEgalite

MerlinEgalite May 18, 2021

Here too

"Cannot set pending balance for zero balance"
);
require(maxTrusts[_adr] != 0, "Address is not a contributor");
require(EnumerableSet.contains(accounts, _adr), "Address is not a contributor");
require(
cstkToken.balanceOf(_adr) == 0,
"User has activated his membership"
Expand All @@ -317,7 +320,7 @@ contract Registry is Context, AdminRole {
_adr != address(0),

This comment has been minimized.

Copy link
@MerlinEgalite

MerlinEgalite May 18, 2021

And here

"Cannot set pending balance for zero balance"
);
require(maxTrusts[_adr] != 0, "Address is not a contributor");
require(EnumerableSet.contains(accounts, _adr), "Address is not a contributor");
require(
cstkToken.balanceOf(_adr) == 0,
"User has activated his membership"
Expand Down

0 comments on commit f9d68d9

Please sign in to comment.