Fix nondeterministic results when add_noise==disable #4518
+8
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Images generated by
KSampler (Advanced)
andSamplerCustom
nodes are nondeterministic whenadd_noise
is set to False.Seems like we need to call
torch.manual_seed(seed)
before sampling in order to get deterministic results.You can reproduce this problem by generating multiple times the same image with a fixed seed on ancestral sampler without adding initial noise.
This PR fixes that issue by moving all
torch.zeros
calls insideprepare_noise
function right after setting torch seed.