Fix issue where using DisableNoise or disabling add_noise results in non-deterministic generations #5306
+5
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…non-deterministic generations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ComfyUI currently has a bug where disabling
add_noisein samplers or using aDisableNoisenode simply does not seed the RNG at all, resulting in non-deterministic generations. #4518 aims to fix that problem by actually seeding the RNG even when adding noise is disabled. this pull takes a slightly different approach: we throw an error when the user attempts to disable noise rather than proceeding anyway and erroneously ignoring the seed.this pull could also be changed to simply remove the
DisableNoisenode andadd_noiseparameters but i thought it would be a bit more friendly to let people load existing workflows.closes #2833