Ensure samplers seed the global RNG even when add_noise is disabled #2841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently no global RNG seed gets set at all with the built in samplers (advanced KSampler, SamplerCustom) if
add_noise
is not enabled. this means anything using the global RNG (i.e.euler_a
) will find the RNG in an undefined state. it becomes impossible to reproduce generations.this simple pull just ensures
torch.manual_seed()
gets called even in the non-add_noise
code path.visual demonstration:
current behavior
with this pull
unfortunately, a lot of other custom nodes copy the current ComfyUI code with this issue and will need to be changed individually.
closes #2833 (i hope)