Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coursier to 2.1.14 #3705

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

alexarchambault
Copy link
Contributor

@alexarchambault alexarchambault commented Oct 10, 2024

Fixes #3695 along with #3701 (the two PRs are needed)

@lihaoyi
Copy link
Member

lihaoyi commented Oct 10, 2024

@alexarchambault can you elaborate a bit on what the version bump pulls in?

@lihaoyi
Copy link
Member

lihaoyi commented Oct 10, 2024

And how does this PR fix the other two PRs? Does it render them redundant? is this PR needed for those to land, or vice versa?

@alexarchambault
Copy link
Contributor Author

Yeah, this bumps coursier to 2.1.14, which pulls coursier/coursier#3093 (makes coursier fetch klib files out-of-the-box). This, alongside #3701 (which stops making Mill discard non-*.jar files from coursier, and just trusts coursier to filter artifacts), fixes #3695.

@lihaoyi
Copy link
Member

lihaoyi commented Oct 10, 2024

Sounds good. The failure looks unrelated, let me merge these two PRs

@lihaoyi lihaoyi merged commit 9a3c110 into com-lihaoyi:main Oct 10, 2024
23 of 24 checks passed
@alexarchambault alexarchambault deleted the bump-coursier branch October 10, 2024 09:49
@lefou lefou added this to the 0.12.0 milestone Oct 10, 2024
lihaoyi added a commit that referenced this pull request Oct 10, 2024
Takes advantage of the new klib support pulled in by
#3705

We don't support the `module` file indirection, so for now we have to
reference the `-js` version of the artifact directly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Kotlin 2.0/Multiplatform artifacts during dependency resolution
3 participants