Fetch klib artifacts too #3702
Closed
Fetch klib artifacts too #3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artifacts should already be filtered by coursier.Artifacts (via classifiers and artifact types stuff)
|
Includes #3701, opened it to check whether it breaks things on its own |
|
The fix here (currently, second commit) should only be temporary. Working on a proper fix, that should be two-fold:
|
lefou
reviewed
Oct 10, 2024
| @@ -104,7 +108,7 @@ trait CoursierSupport { | |||
| Agg.from( | |||
| res.files | |||
| .map(os.Path(_)) | |||
| .filter(path => path.ext == "jar" && resolveFilter(path)) | |||
| .filter(resolveFilter) | |||
There was a problem hiding this comment.
To preserve previous behavior, you should change the resolveFilter default to contain the path.ext == "jar" match, I guess.
There was a problem hiding this comment.
Answered in #3701 (comment)
|
Just tried this out, seems to satisfy the manual test described in #3695 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick workaround for #3695