-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch klib artifacts too #3702
Fetch klib artifacts too #3702
Conversation
Artifacts should already be filtered by coursier.Artifacts (via classifiers and artifact types stuff)
Includes #3701, opened it to check whether it breaks things on its own |
The fix here (currently, second commit) should only be temporary. Working on a proper fix, that should be two-fold:
|
@@ -104,7 +108,7 @@ trait CoursierSupport { | |||
Agg.from( | |||
res.files | |||
.map(os.Path(_)) | |||
.filter(path => path.ext == "jar" && resolveFilter(path)) | |||
.filter(resolveFilter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To preserve previous behavior, you should change the resolveFilter
default to contain the path.ext == "jar"
match, I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Answered in #3701 (comment)
Just tried this out, seems to satisfy the manual test described in #3695 |
Quick workaround for #3695