Open
Conversation
Razaloc
force-pushed
the
wip/rafaelgarrui/integritybmap
branch
9 times, most recently
from
8cea86a to
4004d0f
Compare
Razaloc
force-pushed
the
wip/rafaelgarrui/integritybmap
branch
3 times, most recently
from
e513da0 to
ed62867
Compare
Contributor
Author
|
Bmap integrity check |
Razaloc
force-pushed
the
wip/rafaelgarrui/integritybmap
branch
2 times, most recently
from
96f9991 to
bcfa4cf
Compare
bmap_file_checksum is going to be used to check the integrity of the file. It is now included in the Bmap struct type and the builder. Signed-off-by: Rafael Garcia Ruiz <rafael.garcia@collabora.com>
Before using a Bmap file checks if its checksum is correct for the current bmap file. Bmap checksum is the application of Sha256 to the file data. When the bmap file is created, the value of the checksum has to be zero (all ASCII "0" symbols). Once calculated, zeros are replaced by the checksum, notice this modifies the file itself. In order to calculate the checksum before using it and compare it with the original, we need to set the field as all "0" before applying Sha256. Closes: #50 Signed-off-by: Rafael Garcia Ruiz <rafael.garcia@collabora.com>
Remote copy checks the integrity of the bmap file after downloading it. Signed-off-by: Rafael Garcia Ruiz <rafael.garcia@collabora.com>
Razaloc
force-pushed
the
wip/rafaelgarrui/integritybmap
branch
from
bcfa4cf to
1ac7fed
Compare
Contributor
|
@copilot please rebase this |
Contributor
|
@sjoerdsimons I've opened a new pull request, #104, to work on those changes. Once the pull request is ready, I'll request review from you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks if the bmap hash is correct for the current bmap file.
Bmap file checksum is calculated having that field as all 0s.
Closes: #50
Signed-off-by: Rafael Garcia Ruiz rafael.garcia@collabora.com