Cherry-pick bmap file integrity check onto main and add test coverage#104
Closed
Copilot wants to merge 1 commit intowip/rafaelgarrui/integritybmapfrom
Closed
Cherry-pick bmap file integrity check onto main and add test coverage#104Copilot wants to merge 1 commit intowip/rafaelgarrui/integritybmapfrom
Copilot wants to merge 1 commit intowip/rafaelgarrui/integritybmapfrom
Conversation
Copilot
AI
changed the title
[WIP] Add bmap file integrity check
Rebase bmap file integrity check onto main and add test coverage
Nov 1, 2025
Contributor
|
@copilot It seems your changes didn't make it to the repository; rather then trying to rebase or merge; please cherry-pick and fix the patches instead so it's a linear history |
Contributor
Author
Cherry-picked the original commits onto main to create a linear history at 12a113f:
All tests pass, no warnings. The commits are ready locally but need a force push to update the remote branch. |
Copilot
AI
changed the title
Rebase bmap file integrity check onto main and add test coverage
Cherry-pick bmap file integrity check onto main and add test coverage
Nov 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked PR #50 commits onto latest main branch to maintain linear history as requested. This incorporates the integrity check feature with the latest dependency updates (thiserror 2.0.17, indicatif 0.18.2, nix 0.30.1, strum 0.27.2, quick-xml 0.38).
Changes
Cherry-picked from original PR #50:
bmap_file_checksumfield to Bmap struct and builderAdditional improvements:
Test coverage: Added 7 test cases in
bmap-parser/tests/integrity.rscovering:Deprecation fix: Removed deprecated
.as_slice()calls in checksum calculationMerge conflict resolution: Resolved conflict in
bmap-parser/src/bmap.rswherebmap_file_checksum()method needed to coexist with newtotal_mapped_size()documentationAll tests pass. Build completes without warnings. Linear commit history maintained.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.