Skip to content

Conversation

finscn
Copy link
Contributor

@finscn finscn commented Aug 31, 2025

删除不再使用的 commitIA() 方法.
这个 Batcher2D 类你们从来没有暴路出来过 , cocos 的用户们几乎不可能用到 commitIA() 方法.
而你们代码内部 也没有用.
因为 @deprecated since v3.6.2, please use [[commitMiddleware]] instead .

现在你们内部都在用 commitMiddleware 了.

所以这个 方法删了吧.
你们不是总想着缩小代码体积吗, 这种没用过的方法能删尽量删吧.

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

删除不再使用的 `commitIA()` 方法.
 这个 Batcher2D 类你们从来没有暴路出来过 ,  cocos 的用户们几乎不可能用到 commitIA() 方法.
而你们代码内部 也没有用.
因为 `@deprecated since v3.6.2, please use [[commitMiddleware]] instead` .

现在你们内部都在用 commitMiddleware 了.

所以这个 方法删了吧.
你们不是总想着缩小代码体积吗, 这种没用过的方法能删尽量删吧.
Copy link

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1009429 bytes 1008868 bytes 👍 -561 bytes
2D All (legacy pipeline) 2674774 bytes 2674213 bytes 👍 -561 bytes
2D All (new pipeline) 2765676 bytes 2765115 bytes 👍 -561 bytes
(2D + 3D) All 10022031 bytes 10021466 bytes 👍 -565 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16841090 bytes 16840525 bytes 👍 -565 bytes

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -3682,22 +3682,8 @@
          */
         commitComp(comp: UIRenderer, renderData: BaseRenderData | null, frame: __private._cocos_asset_assets_texture_base__TextureBase | SpriteFrame | null, assembler: IAssembler, transform: Node | null): void;
         /**
          * @en
-         * Render component data submission process for individual [[gfx.InputAssembler]]
-         * @zh
-         * 渲染组件中针对独立 [[gfx.InputAssembler]] 的提交流程
-         * 例如:Spine 和 DragonBones 等包含动态数据和材质的组件在内部管理 IA 并提交批次
-         * @param comp - The committed renderable component
-         * @param ia - The committed [[gfx.InputAssembler]]
-         * @param tex - The texture used
-         * @param mat - The material used
-         * @param [transform] - The related node transform if the render data is based on node's local coordinates
-         * @deprecated since v3.6.2, please use [[commitMiddleware]] instead
-         */
-        commitIA(renderComp: UIRenderer, ia: gfx.InputAssembler, tex?: __private._cocos_asset_assets_texture_base__TextureBase, mat?: Material, transform?: Node): void;
-        /**
-         * @en
          * Render component data submission process for middleware2d components
          * @zh
          * 渲染组件中针对2D中间件组件渲染数据的提交流程
          * 例如:Spine 和 DragonBones 包含动态数据和材质的组件

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant