Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cb17 fixup #640

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Cb17 fixup #640

wants to merge 2 commits into from

Conversation

lil-cain
Copy link
Contributor

Fixes for changes requested for #570

I've had to remove the lambda used to input logs to elasticsearch, as it relied on a javascript file that's not in the PR. There's also some other changes required to make the troposphere templates actually compile - Exports were a dictionary, so I modified them to be a troposphere.export

I haven't reviewed the actually generated templates to check they make sense :-)

msirull added 2 commits January 12, 2017 00:55
This is the network stack which containers an ECS cluster with ALB and ElasticSearch cluster. This also leverages the new cross-stack functionality
This is the app stack which contains an ECS Task Definition that attaches to an ECS cluster and a CloudWatch Logs group which streams logs to an ElasticSearch cluster from the network template. This also leverages the new cross-stack functionality
@phobologic
Copy link
Member

@lil-cain The tests for this are failing - any chance you can take a look at it?

@lil-cain
Copy link
Contributor Author

lil-cain commented Jan 26, 2017 via email

@phobologic
Copy link
Member

Thanks @lil-cain ! Good luck with your paternity leave :)

@lil-cain
Copy link
Contributor Author

lil-cain commented Mar 1, 2017

Hey - just been looking at this again - it looks like there's an issue in template_generator._generate_autoscaling_metadata, in that this assumes that AWS::CloudFormation::Init will always have a single key (config). From the cloud formation docs though, you can have multiple keys in this dict, with only configsets being required in this case.

Am I barking up entirely the wrong tree with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants