Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New ALB-ECS templates #570

Closed
wants to merge 2 commits into from
Closed

New ALB-ECS templates #570

wants to merge 2 commits into from

Conversation

automartin5000
Copy link
Contributor

No description provided.

msirull added 2 commits September 19, 2016 14:22
Create ALB-ECS-WithElasticSearchLogs-NetworkStack
d290712 
This is the network stack which containers an ECS cluster with ALB and ElasticSearch cluster. This also leverages the new cross-stack functionality
Create ALB-ECS-WithElasticSearchLogs-AppStack
5a334b0 
This is the app stack which contains an ECS Task Definition that attaches to an ECS cluster and a CloudWatch Logs group which streams logs to an ElasticSearch cluster from the network template. This also leverages the new cross-stack functionality
phobologic
phobologic requested changes Oct 24, 2016
View reviewed changes
Copy link
Member

@phobologic phobologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these files are being skipped by tests because they aren't .py files, but I'm not sure 100%. You also should make sure to add the expected resulting JSON to tests/examples_output. This looks awesome though, thanks!

examples/ALB-ECS-WithElasticSearchLogs-AppStack
@@ -0,0 +1,344 @@
from troposphere import Join, GetAtt, ImportValue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a .py file, like the rest in the examples directory

examples/ALB-ECS-WithElasticSearchLogs-NetworkStack
@@ -0,0 +1,540 @@
import troposphere.elasticloadbalancingv2 as elb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file name should end with .py (ALB-ECS-WithElasticSearchLogs-NetworkStack -> ALB-ECS-WithElasticSearchLogs-NetworkStack.py)

@kpx-dev
Copy link

kpx-dev commented Dec 13, 2016

this is awesome guys, I just used this example to launch an ECS cluster with ALB!

@lil-cain lil-cain mentioned this pull request Jan 12, 2017
Open
@phobologic
Copy link
Member

Ping @cb17 - any chance you can update this?

@patrickpierson
Copy link
Contributor

I was able to get the APP stack to work. The network stack is having issues on the later versions of troposphere. Given that @cb17 hasnt responded. I think this is closable and we could use the APP stack example to close this in another PR. Same for #640

@automartin5000
Copy link
Contributor Author

@patrickpierson @phobologic Hi guys, sorry for the radio silence. I had been meaning to circle back around to this, but got a little disconnected from these templates. FWIW, the code for the ElasticSearch JS Lambda function I just stole from what gets generated in the console (and minified it, and added a "var esdomain = Ref(ESDomain)" to the front of it). So if someone wants to add that back in, I'm sure it could be useful to someone.

@patrickpierson
Copy link
Contributor

I think that since this PR is over a year old it makes sense to close it and if you want to create a new one based on the newer version of troposphere it would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phobologic phobologic phobologic requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@automartin5000 @kpx-dev @phobologic @patrickpierson