-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make popover white-space style deterministic #3047
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3047 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 780 780
Lines 21927 21928 +1
Branches 7503 7513 +10
=======================================
+ Hits 21126 21127 +1
Misses 749 749
Partials 52 52 ☔ View full report in Codecov by Sentry. |
d322dc8
to
1e4df39
Compare
@@ -14,12 +14,9 @@ | |||
direction: inherit; | |||
empty-cells: show; | |||
font-family: serif; | |||
font-size: medium; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that these 3 rules were unnecessary because they are overriden by the typography.default-text-style
mixin which is included further down
This reverts commit 6605b1c.
This reverts commit 6605b1c.
Description
Ticket: AWSUI-60034
The same element had the CSS rule
white-space: normal
andwhite-space: nowrap
with the same specificity, so the final style of the element couldn't be guaranteed. The specific order in which stylesheets are loaded can break the expected component appearance.How has this been tested?
white-space: nowrap
rule has higher specificity (1,2,0) than the one with thewhite-space: normal
rule (1,1,0)Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.