Skip to content

Commit d322dc8

Browse files
committed
fix: Make popover white-space style deterministic
1 parent 66976ad commit d322dc8

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

src/copy-to-clipboard/internal.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export default function InternalCopyToClipboard({
6363
const isInline = variant === 'inline';
6464
const trigger = (
6565
<InternalPopover
66-
className={clsx(isInline && styles['inline-trigger'])}
66+
isInline={isInline}
6767
size="medium"
6868
position="top"
6969
triggerType="custom"

src/copy-to-clipboard/styles.scss

-4
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,3 @@
1616
margin-inline-end: awsui.$space-scaled-xxs;
1717
}
1818
}
19-
20-
.inline-trigger {
21-
white-space: nowrap;
22-
}

src/internal/styles/utils/styles-reset.scss

-3
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,9 @@
1414
direction: inherit;
1515
empty-cells: show;
1616
font-family: serif;
17-
font-size: medium;
1817
font-style: normal;
1918
font-variant: normal;
20-
font-weight: 400;
2119
font-stretch: normal;
22-
line-height: normal;
2320
hyphens: none;
2421
letter-spacing: normal;
2522
list-style: disc outside none;

src/popover/internal.tsx

+5-1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ export interface InternalPopoverProps extends Omit<PopoverProps, 'triggerType' |
2828
triggerType?: PopoverProps.TriggerType | 'filtering-token';
2929
size: PopoverProps.Size | 'content';
3030
__closeAnalyticsAction?: string;
31+
isInline?: boolean;
3132
}
3233

3334
export interface InternalPopoverRef {
@@ -56,6 +57,8 @@ function InternalPopover(
5657
__onOpen,
5758
__internalRootRef = null,
5859
__closeAnalyticsAction,
60+
isInline,
61+
5962
...restProps
6063
}: InternalPopoverProps,
6164
ref: React.Ref<InternalPopoverRef>
@@ -186,7 +189,8 @@ function InternalPopover(
186189
className={clsx(
187190
styles.root,
188191
baseProps.className,
189-
triggerType === 'filtering-token' && styles['root-filtering-token']
192+
triggerType === 'filtering-token' && styles['root-filtering-token'],
193+
isInline && styles.inline
190194
)}
191195
ref={mergedRef}
192196
onMouseDown={() => {

src/popover/styles.scss

+3
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@
1515
.root {
1616
@include styles.styles-reset;
1717
color: inherit;
18+
&.inline {
19+
white-space: nowrap;
20+
}
1821
}
1922

2023
.root-filtering-token {

0 commit comments

Comments
 (0)