feat: Improve breadcrumb group responsivness #3025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3025 +/- ##
==========================================
+ Coverage 96.35% 96.36% +0.01%
==========================================
Files 779 781 +2
Lines 21925 21935 +10
Branches 7112 7521 +409
==========================================
+ Hits 21125 21138 +13
+ Misses 793 790 -3
Partials 7 7 ☔ View full report in Codecov by Sentry. |
gethinwebster
force-pushed
the
dev-v3-gethinw-breadcrumb-mobile
branch
from
ad8c697 to
6bb0874
Compare
gethinwebster
force-pushed
the
dev-v3-gethinw-breadcrumb-mobile
branch
from
ad465e9 to
ef8aed8
Compare
gethinwebster
changed the title
pan-kot
reviewed
Nov 26, 2024
gethinwebster
force-pushed
the
dev-v3-gethinw-breadcrumb-mobile
branch
from
776ad89 to
3a0fa8f
Compare
pan-kot
reviewed
Nov 29, 2024
src/button-dropdown/interfaces.ts
Outdated
| @@ -258,6 +258,7 @@ export interface ItemProps { | |||
|
|
|||
| export interface InternalItem extends ButtonDropdownProps.Item { | |||
| badge?: boolean; | |||
| isCurrentPage?: boolean; | |||
There was a problem hiding this comment.
nit: I think it worths adding a doc comment to the new isCurrentPage and fullWidth to explain the purpose.
There was a problem hiding this comment.
update: is isCurrentPage used? I think it was replaced by the isCurrentBreadcrumb, right?
There was a problem hiding this comment.
good catch! took the opportunity to deduplicate these interfaces a bit too
| // SPDX-License-Identifier: Apache-2.0 | ||
| import clsx from 'clsx'; | ||
|
|
||
| export const spinWhenOpen = (styles: Record<string, string>, className: string, open: boolean) => |
pan-kot
previously approved these changes
Nov 29, 2024
gethinwebster
force-pushed
the
dev-v3-gethinw-breadcrumb-mobile
branch
from
7736f1c to
88759d0
Compare
pan-kot
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves breadcrumb group responsiveness so that:
Related links, issue #, if available: 3SICARmRNK32
How has this been tested?
Updated unit and integ tests
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.