Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Top navigation icon direction #3117

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix: Top navigation icon direction #3117

merged 1 commit into from
Dec 10, 2024

Conversation

gethinwebster
Copy link
Member

Description

Recent refactoring (#3025) caused top nav button to be reversed, this fixes that regression.

Related links, issue #, if available: n/a

How has this been tested?

Local testing.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.37%. Comparing base (de3ec21) to head (450a02f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3117    +/-   ##
========================================
  Coverage   96.37%   96.37%            
========================================
  Files         783      783            
  Lines       22039    22039            
  Branches     7150     7495   +345     
========================================
  Hits        21241    21241            
+ Misses        791      746    -45     
- Partials        7       52    +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gethinwebster gethinwebster added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit c0c9f2e Dec 10, 2024
38 checks passed
@gethinwebster gethinwebster deleted the top-nav-icon-fix branch December 10, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants