refactor(core): change scaffolding to use kubebuilder v4 structure#989
Merged
refactor(core): change scaffolding to use kubebuilder v4 structure#989
Conversation
6c41277 to
8de0761
Compare
dd30cff to
131bfb3
Compare
kengou
requested changes
Apr 2, 2025
Collaborator
kengou
left a comment
There was a problem hiding this comment.
We need this 2 files for infra automation
config/manifest/flux-installation-main.yaml
config/manifest/flux-installation-release.yaml
2b9a5cd to
267dd94
Compare
267dd94 to
518629f
Compare
Contributor
|
could we remove the sub-folder greenhouse in the api section? Instead of Let's keep We would need to update the import paths everywhere, which I addressed in - https://github.com/cloudoperators/greenhouse/tree/feat/enable-conversion-webhooks |
- update import paths - update references - regenerate
518629f to
2d42fc4
Compare
kengou
previously approved these changes
Apr 7, 2025
uwe-mayer
previously approved these changes
Apr 8, 2025
kengou
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the structure of the repository to more closely follow the kubebuilder/v4 scaffolding.
The previous structure was not following any kubebuilder scaffolding, thus made it hard to generate new apis/controllers/webhooks.
This also changes how CRDs are generated. In order to make patching the CRDs easier the makefile now builds the CRDs with kustomize and then copies them into the helm chart.
TODO:
/configfolder, this currently contains all auto generated kustomize fileshack/helmify.shand potentially replace this with kustomize patchesWhat type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist