Skip to content

fix(e2e): removes deprecated fields from the appProps.json creation#1049

Merged
IvoGoman merged 3 commits intomainfrom
fix/olandr-appProps-update
Apr 28, 2025
Merged

fix(e2e): removes deprecated fields from the appProps.json creation#1049
IvoGoman merged 3 commits intomainfrom
fix/olandr-appProps-update

Conversation

@olandr
Copy link
Member

@olandr olandr commented Apr 2, 2025

Description

  • Removes 'mockAuth' from the default appProps.json (deprecated in juno)
  • Removes 'environment' from charts/dashboards (deprecated in juno, commit)

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #1048

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@olandr olandr requested review from a team as code owners April 2, 2025 10:11
@olandr olandr linked an issue Apr 2, 2025 that may be closed by this pull request
@olandr olandr changed the title fix(dev-env): removes deprecated fields from the appProps.json creation fix(e2e): removes deprecated fields from the appProps.json creation Apr 2, 2025
Copy link
Contributor

@IvoGoman IvoGoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you bump the dashboard chart?

IvoGoman
IvoGoman previously approved these changes Apr 22, 2025
@IvoGoman
Copy link
Contributor

@olandr could you rebase once on main? With #989 the repo got restructured and the file is now unter internal/local/setup/dashboard.go

@IvoGoman IvoGoman force-pushed the fix/olandr-appProps-update branch from 7f781ca to 3ba344f Compare April 28, 2025 11:32
olandr added 3 commits April 28, 2025 13:46
This removes the 'mockAuth' prop from the default appProps.json creation for the dev-env

---------

Signed off by: Simon Olander (simon.olander@sap.com)
See cloudoperators/juno@15de112

---------

Signed off by: Simon Olander (simon.olander@sap.com)
@IvoGoman IvoGoman force-pushed the fix/olandr-appProps-update branch from 3ba344f to 02246fe Compare April 28, 2025 11:46
@IvoGoman IvoGoman merged commit 9e34e87 into main Apr 28, 2025
23 checks passed
@IvoGoman IvoGoman deleted the fix/olandr-appProps-update branch April 28, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Outdated appProps breaking login to 'demo' org

4 participants