add button for feature combinations #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks @johenglisch ! Let's leave the position as is now, if anyone has opinions I'll figure out if they're worthwhile and let you know :) All features should be combinable please :) |
xrotwang
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Instead of importing DBSession, you can use request.db in the template, see https://github.com/clld/clld/blob/837351371d150f43c4945140d3ec1f2027375f6a/src/clld/web/app.py#L65-L72
|
Thanks! So, as far as I'm concerned this is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button exists now (see picture -- I haven't deployed it yet).
@HedvigS I'm not entirely sure where the button should actually go on the page. For now I put it at the bottom of the description section (right above the map). So, if you want me to move it somewhere else, just tell me.
Also, which features should be combinable here? All of them or only the ones listed in Related features (this branch does the former rn)?
@xrotwang The code in the template feels a bit weird (like, the part where I import DBSession into the template). Is there a more idiomatic way to do this that I'm missing?