Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining features #23

Closed
HedvigS opened this issue Dec 10, 2020 · 13 comments · Fixed by #44
Closed

Combining features #23

HedvigS opened this issue Dec 10, 2020 · 13 comments · Fixed by #44
Assignees
Milestone

Comments

@HedvigS
Copy link
Collaborator

HedvigS commented Dec 10, 2020

In past versions of the website there was a way of combining features and see the distributions of combinations. This functionality is not there anymore. Can you refresh me @xrotwang to why that is? I've got people asking if it can be brought back, and I'm not sure how involved that is.

@HedvigS
Copy link
Collaborator Author

HedvigS commented Dec 10, 2020

It seems it's still possible through URL manipulation
https://grambank.clld.org/combinations/GB118_GB150#2/17.1/151.9

@xrotwang
Copy link
Member

xrotwang commented Dec 10, 2020

We haven't come up with a final list of functionalities for the website yet, I think. We can use issues here as proposed functionalities - maybe tagged suitably as "enhancement".

@HedvigS
Copy link
Collaborator Author

HedvigS commented Dec 10, 2020

Sure thing! I know Simon wanted to add trees (#12 ) and I'm sure people have other ideas as well.

For now, I just wanted to keep it small and ask if this thing that used to be there can be there again :)

@HedvigS
Copy link
Collaborator Author

HedvigS commented Apr 16, 2021

So, do we want a GUI for this?

@HedvigS
Copy link
Collaborator Author

HedvigS commented Jul 15, 2021

Got a request from the CoOL gang to have this. What do you think @xrotwang

@xrotwang
Copy link
Member

issue is already open. so all good :)

@HedvigS
Copy link
Collaborator Author

HedvigS commented Jul 15, 2021

Great, thanks Robert!

@HedvigS
Copy link
Collaborator Author

HedvigS commented Mar 1, 2023

The Grambank manuscript is advancing in the submission system, we may be looking at a publication soon. Is it possible to get a button with rounded corners for this functionality within 2 months?

@xrotwang
Copy link
Member

xrotwang commented Mar 1, 2023

I don't understand what "button with rounded" means, but maybe @johenglisch can look into this.

@HedvigS
Copy link
Collaborator Author

HedvigS commented Mar 1, 2023

Okay.

It would be nice if the funcationality on the website whereby you could click a button that said "combine features" and search for features and get to the combined map is brought back. "button with rounded corners" is my shorthand for GUI interface function for the underlying tool that already exists.

@HedvigS
Copy link
Collaborator Author

HedvigS commented Mar 1, 2023

example from dplace website
Screenshot 2023-03-01 at 12 54 27

@johenglisch
Copy link
Contributor

I'll take a look at it.

So, basically there's functionality in the webapp that's there but not exposed in the ui? That should be simple (in theory).

Where is this form supposed to go? From the wording it looks like it's from the page of a particular GB feature?

@HedvigS
Copy link
Collaborator Author

HedvigS commented Mar 2, 2023

@johenglisch yes exactly. we patrons use the URL and modify that to get the functionality, but it would be great if it's in the UI directly.
It can go where-ever is easiest, I'm not too fussed. I think other CLLD webapps have it, so whereever they have it I'm sure is good :)

@xrotwang xrotwang added this to the Grambank 1.0 milestone Mar 6, 2023
@johenglisch johenglisch linked a pull request Mar 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants