Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumped Puppeteer to the latest version and switched to the new headless mode #918

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Bumped Puppeteer to the latest version and switched to the new headless mode #918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
eca1f47
Bumped Puppeteer to v21.1.1 and switched to new headless mode.
psmyrek Aug 31, 2023
38d86b6
Merge branch 'master' into fix-crawler-failures-on-ci
psmyrek Sep 13, 2023
f3bc8ca
Bumped Puppeteer to the latest version.
psmyrek Sep 13, 2023
c7988e0
Debugging.
psmyrek Sep 13, 2023
fe4a361
Debugging.
psmyrek Sep 13, 2023
d8f0182
Merge branch 'master' into fix-crawler-failures-on-ci
psmyrek Oct 4, 2023
833057c
Debugging.
psmyrek Oct 5, 2023
6b4be63
Debugging.
psmyrek Oct 5, 2023
a08cb8c
Debugging.
psmyrek Oct 5, 2023
c66182b
Debugging.
psmyrek Oct 5, 2023
709d960
The "old" headless mode.
psmyrek Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/ckeditor5-dev-web-crawler/lib/runcrawler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,14 @@ async function createBrowser( options ) {

const browser = await puppeteer.launch( browserOptions );

const [ defaultBlankPage ] = await browser.pages();
// For unknown reasons, in order to be able to visit pages in Puppeteer on CI, we must close the default page that is opened when the
// browser starts.
if ( process.env.CI ) {
const [ defaultBlankPage ] = await browser.pages();

if ( defaultBlankPage ) {
await defaultBlankPage.close();
if ( defaultBlankPage ) {
await defaultBlankPage.close();
}
}

return browser;
Expand Down
2 changes: 1 addition & 1 deletion packages/ckeditor5-dev-web-crawler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dependencies": {
"chalk": "^4.1.0",
"ora": "^5.2.0",
"puppeteer": "^19.7.5",
"puppeteer": "^21.3.6",
"strip-ansi": "^6.0.0"
},
"engines": {
Expand Down