Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped Puppeteer to the latest version and switched to the new headless mode #918

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

psmyrek
Copy link
Contributor

@psmyrek psmyrek commented Sep 5, 2023

Suggested merge commit message (convention)

Internal: Bumped Puppeteer to the latest version and switched to the new headless mode. New Puppeteer includes a fix for handling <iframe> in manual tests that no longer throws connection timeout. Closes ckeditor/ckeditor5#14906.


Additional information

To do list before merging this PR:

@pomek
Copy link
Member

pomek commented Sep 6, 2023

Once we merge the PR, it would be good to revert this change: ckeditor/ckeditor5@a5e3a03.

@coveralls
Copy link

coveralls commented Sep 13, 2023

Coverage Status

coverage: 90.149%. remained the same when pulling 709d960 on fix-crawler-failures-on-ci into 43eabd2 on master.

@psmyrek
Copy link
Contributor Author

psmyrek commented Sep 13, 2023

@psmyrek
Copy link
Contributor Author

psmyrek commented Oct 5, 2023

I did a few more checks:

  • Installed the newest Puppeteer v21.3.6.
  • The new headless: 'new' mode is unstable on CI, but locally it works quite fine. On CI there is always the following error: TargetCloseError: Protocol error (Browser.close): Target closed and Failed to open a new tab - see example job.
  • The old headless: 'old' mode works in the same way as previously: the net::ERR_ABORTED is thrown from the noselection-iframe manual test: see example job.

It seems that we should wait for the new stable Chromium release that contains a fix, and then wait for the new Puppeteer that uses the fixed version of the Chromium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web crawler randomly fails on some manual test on CI
3 participants