Skip to content

Conversation

@elad-eyal
Copy link
Contributor

No description provided.

@chriskiehl
Copy link
Owner

Few things before they go in (these apply to #18 as well):

1. squash your commits. I'm finicky about such things : )

2. I'd prefer to see these in a different package, something like examples/user-input (or some better name).

with the rational being:

3. you need to specify your dependencies

Probably either via an optional-requirements.txt at the root level, or another requirements.txt inside of your package. I'd prefer not to have them in the main requirements.txt as I don't want people to have to install a bunch of things other than Gooey just to run the main Gooey examples. People getting WX reliably installed across different platforms is already a pain. I'd rather keep additional GUI libraries out of the main flow of things (based on a cursory glace at PyGUI's Qt usage).

4. update the README

Explain the extra dependencies required to run your user input examples. Additionally, you should fail gracefully when they ignore the README and try to run your stuff anyways ^_^

@chriskiehl
Copy link
Owner

Inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants