Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from verilator:master #614

Merged
merged 133 commits into from
Nov 21, 2023
Merged

Commits on Oct 15, 2023

  1. Configuration menu
    Copy the full SHA
    4e2c63c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4427f03 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4fdaa46 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bba3487 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Configuration menu
    Copy the full SHA
    25dde58 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ad3bcbb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bc9ff6d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    99ea16d View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Configuration menu
    Copy the full SHA
    e99fd28 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    45edcbb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3bb9c7e View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Configuration menu
    Copy the full SHA
    431bb1e View commit details
    Browse the repository at this point in the history
  2. Apply 'make format'

    github action committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    770cd24 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    13989b9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3914176 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2862545 View commit details
    Browse the repository at this point in the history
  6. cmake: Fix missing headers

    wsnyder committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    51a1822 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b5828a7 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8b44a54 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    493f1da View commit details
    Browse the repository at this point in the history
  10. Commentary (#4580)

    wsnyder committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    263697e View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    8720841 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b7233d0 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    0c2bab1 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Configuration menu
    Copy the full SHA
    5af271c View commit details
    Browse the repository at this point in the history
  2. Cleanup some IEEE references

    wsnyder committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    a773a52 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Configuration menu
    Copy the full SHA
    4cc4213 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    05bb7fa View commit details
    Browse the repository at this point in the history
  3. Support wait fork (#4586)

    kiryk authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    83a0085 View commit details
    Browse the repository at this point in the history
  4. Support Clang 16 (#4592)

    mglb authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    c7a0613 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. Configuration menu
    Copy the full SHA
    7b12f6a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f8b7fb7 View commit details
    Browse the repository at this point in the history
  3. Fix PLI/DPI user defined system task/function grammar (#4587) (#4588)

    According to 1800-2017 36.3, 1800-2017 A.9.3, 1364-2005 20.2 and 1364-2005 A.9.3, user defined system task and function identifiers can use the same character set for the second character as all the following characters.
    dwRchyngqxs authored Oct 21, 2023
    Configuration menu
    Copy the full SHA
    26e3785 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cbc2f9e View commit details
    Browse the repository at this point in the history
  5. Fix conditionals on obsolete --threads 0

    Since we removed --threads 0 support, the 'threads()' option always
    returns a value >= 1. Remove corresponding dead code.
    
    Some of the coverage counters appear to use atomics even if the model is
    single threaded. I'm under the impression this was a bug originally so
    those ones I changed to use threads() > 1 instead.
    gezalore committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    d1c7875 View commit details
    Browse the repository at this point in the history
  6. Commentary

    wsnyder committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    332a687 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    afaa027 View commit details
    Browse the repository at this point in the history
  8. Consider children of AstConcat in V3InstrCount

    Previously V3InstrCount used to completely ignore an AstConcat,
    including its children (see the rational in the comment). The problem is
    the operands can be huge and expensive compound expressions (especially
    since DFG), and not just a simple variable reference. This fix gains
    some MT speed improvement.
    gezalore committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    1075b00 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    eae942b View commit details
    Browse the repository at this point in the history
  10. Make VL_LOCK_SPINS configurable

    It's unlikely one value fits all use case, so making VL_LOCK_SPINS
    configurable at model build time.
    
    For testing, we reduce the value as we expect high contention.
    gezalore committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    b78ea06 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    10d3323 View commit details
    Browse the repository at this point in the history
  12. Trivial simplification of V3EmitCModel

    Still some remains of the --threads 0 mode. Remove unnecessary complexity
    from V3EmitCModel. (Also don't pretend there is an MTask in single
    threaded mode, when there really isn't.)
    gezalore committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    a09506a View commit details
    Browse the repository at this point in the history
  13. Remove pointless test

    t_optm_if_cond was a test for a then non-existent optimization to merge
    conditionals. V3MergeCond implements this and has its own tests.
    gezalore committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    52f2b9e View commit details
    Browse the repository at this point in the history
  14. Remove V3AstConstOnly.h

    This is now redundant with the introduction of VNVisitorConst
    gezalore committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    146cdc0 View commit details
    Browse the repository at this point in the history
  15. Improve --prof-exec infrastructure and report

    Again --prof-exec have bit-rotted a little with all the recent changes
    to the structure of the generated code. This patch contains a few
    improvements:
    - Repalce the eval/evl_loop begin/end events with generic
      section_push/section_pop events, that can be arbitrarily sprinkled
      into the generate code (so long as they are matched correctly) to
      measure various sections. The report then contains a nested profile
      of the sections, and the VCD trace shows the section names.
    - Better handling of exec graphs
    - Clearer overall statistics
    gezalore committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    4c0edd2 View commit details
    Browse the repository at this point in the history
  16. Create implicit nets for inputs of gate primitives.

    Prior to this we failed to create implicit nets for inputs of gate
    primitives, which is required by the standard (IEEE 1800-2017 6.10).
    Note: outputs were covered due to being modeled as the LHS of
    assignments, which do create implicit nets.
    gezalore committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    d330100 View commit details
    Browse the repository at this point in the history
  17. Simplify and fix code stats

    V3Stats for "fast" code have bit-rotted a little and is causing some
    problems with tests that rely on stats outputs. The problem is that not
    all code is necessarily reachable from eval() any more (due to the
    complexity of some the features added over the past few years), so it
    might miss some things, as for measuring the "fast" code, it is trying
    to trace the execution paths via calls, starting from eval(). It also
    appears the fast code can also contain calls to slow code in some
    circumstances.
    
    To avoid all that, removed trying to trace dynamic execution, and simply
    report the static node counts, which is enough for testing.
    
    Similarly, the variable counts are somewhat dubious, as they don't
    include all data types, or all instances of a module in some stages.
    Removing these as they are not widely used nor dependable. More specific
    stats can be added if required and can be well defined.
    gezalore committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    978d900 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    8256569 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2023

  1. Configuration menu
    Copy the full SHA
    5bda901 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bcbe505 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b83b997 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Configuration menu
    Copy the full SHA
    33c5b5f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    774c103 View commit details
    Browse the repository at this point in the history
  3. Separate tracing of const values from non-const values

    Some values emitted to the trace files are constant (e.g.: actual
    parameter values), and never change. Previously we used to trace these
    in the 'full' dumps, which also included all other truly variable
    signals. This patch introduces a new generated trace function 'const',
    to complement the 'full' and 'chg' flavour, and 'const' now only
    contains the constant signals, while 'full' and 'chg' contain only the
    truly variable signals. The generate 'full' and 'chg' trace functions
    now have exactly the same shape. Note that 'const' signals are still
    traced using the 'full*' dump methods of the trace buffers, so there is
    no need for a third flavour of those.
    gezalore committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    165a2ef View commit details
    Browse the repository at this point in the history
  4. Apply 'make format'

    github action authored and gezalore committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    1bd3174 View commit details
    Browse the repository at this point in the history
  5. Associate trace codes with function indices (#4610)

    For each traced variable, also register the trace function index that
    will write it.
    gezalore authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    d1b6224 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Configuration menu
    Copy the full SHA
    17721af View commit details
    Browse the repository at this point in the history
  2. Fix virtual methods (#4616)

    RRozak authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    84125d7 View commit details
    Browse the repository at this point in the history
  3. Unify code generation for trace declarations in both trace formats (#…

    …4612)
    
    This patch adds some abstract enums to pass to the trace decl* APIs, so
    the VCD/FST specific code can be kept in verilated_{vcd,fst}_*.cc, and
    removed from V3Emit*. It also reworks the generation of the trace init
    functions (those that call 'decl*' for the signals) such that the scope
    hierarchy is traversed precisely once during initialization, which
    simplifies the FST writer. This later change also has the side effect of
    fixing tracing of nested interfaces when traced via an interface
    reference - see the change in the expected t_interface_ref_trace - which
    previously were missed.
    gezalore authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    95c4ade View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Configuration menu
    Copy the full SHA
    cf6e362 View commit details
    Browse the repository at this point in the history
  2. Fix insertion at queue's end (#4619)

    Signed-off-by: Krzysztof Boronski <[email protected]>
    Co-authored-by: Wilson Snyder <[email protected]>
    kboronski-ant and wsnyder authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    f91259f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    34708bb View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Allow assigning events (#4403)

    Signed-off-by: Krzysztof Boronski <[email protected]>
    kboronski-ant authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    a87fb57 View commit details
    Browse the repository at this point in the history
  2. Include systemc instead of systemc.h in model header files (#4622) (#…

    …4623)
    
    This may require that SystemC programs add:
    using namespace sc_core;
    using namespace sc_dt;
    PkmX authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    9825263 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    64af831 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Configuration menu
    Copy the full SHA
    7395213 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e613598 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    89743aa View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. Configuration menu
    Copy the full SHA
    2cba167 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a5951ba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d842041 View commit details
    Browse the repository at this point in the history
  4. C++11 cleanup

    gezalore committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    30318a6 View commit details
    Browse the repository at this point in the history
  5. Avoid double traversal of maps

    The typical find/if-not-exists-insert pattern can be achieved with 1
    lookup instead of 2 using emplace with a sentinel value. Also maps value
    initialize their values when inserted with the [] operator, this is
    defined and so there is no need to explicitly insert zeroes for integer
    values.
    gezalore committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    d60f180 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    de4c606 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e708670 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. Configuration menu
    Copy the full SHA
    7ba6647 View commit details
    Browse the repository at this point in the history
  2. Delete AstNode user5 (#4638)

    This saves about 5% memory. V3AstUserAllocator is appropriate for most use
    cases, performance is marginally up as we are mostly D-cache bound on
    large designs.
    gezalore authored Oct 29, 2023
    Configuration menu
    Copy the full SHA
    3c144ad View commit details
    Browse the repository at this point in the history
  3. Tests: Rename t_opt_dead

    wsnyder committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    3c6b755 View commit details
    Browse the repository at this point in the history
  4. Update CONTRIBUTORS (#4641)

    Icaro-Lima authored and wsnyder committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    1da1518 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Configuration menu
    Copy the full SHA
    15046c6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c1c8b30 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Fix signals read via virtual iface optimized out (#4645)

    Signed-off-by: Krzysztof Bieganski <[email protected]>
    kbieganski authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    f789d28 View commit details
    Browse the repository at this point in the history
  2. Commentary: Changes update

    wsnyder committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    c241ec9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a27abab View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a764c70 View commit details
    Browse the repository at this point in the history
  5. Commentary: Changes update

    wsnyder committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    5901888 View commit details
    Browse the repository at this point in the history
  6. Version bump

    wsnyder committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    67dfa37 View commit details
    Browse the repository at this point in the history
  7. devel release

    wsnyder committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    839315b View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Commentary (#4517)

    wsnyder committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    2a57ead View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Configuration menu
    Copy the full SHA
    8a77af7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ae6ec41 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2733d43 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Configuration menu
    Copy the full SHA
    d0d39c1 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2023

  1. Configuration menu
    Copy the full SHA
    eace1d9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    88fcbf5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc346b7 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2023

  1. Configuration menu
    Copy the full SHA
    b110c55 View commit details
    Browse the repository at this point in the history
  2. Fix scheduling of external force signals (#4668)

    Used to set the wrong public flag on forceEn/forceVal, which means they
    were not included in ICO as necessary, but V3Gate tended to inline them,
    so this was hard to hit.
    
    Fixes #4577
    gezalore authored Nov 5, 2023
    Configuration menu
    Copy the full SHA
    c563175 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Configuration menu
    Copy the full SHA
    27102ea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dc10118 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Configuration menu
    Copy the full SHA
    5ba7084 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Configuration menu
    Copy the full SHA
    9a65ed4 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Configuration menu
    Copy the full SHA
    ab06ace View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Configuration menu
    Copy the full SHA
    6566e85 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. Fix spelling

    wsnyder committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    f3ae4b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9a0254a View commit details
    Browse the repository at this point in the history
  3. Commentary: Changes update

    wsnyder committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    4286af3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    706534f View commit details
    Browse the repository at this point in the history
  5. Commentary

    wsnyder committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    a64bdf5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4636a7f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cad2780 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4103925 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    673f086 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2023

  1. Configuration menu
    Copy the full SHA
    99dbd23 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d7f5bd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4a10c9e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    91d0f25 View commit details
    Browse the repository at this point in the history
  5. Fix assignment of class reference to itself causing double free.

    Test in next commit.
    wsnyder committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    30a0d62 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    eff2d97 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    671a857 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bea82de View commit details
    Browse the repository at this point in the history
  9. Cleanup V3Gate (#4667) (#4685)

    Lot of redundant/dead/obsolete code here. NFCI, but contains some minor
    bug fixes.
    gezalore authored Nov 12, 2023
    Configuration menu
    Copy the full SHA
    b07ffb3 View commit details
    Browse the repository at this point in the history
  10. Reduce peak memory use of V3Subst (#4687)

    V3Subst is currently the pass responsible for peak memory usage. This
    patch saves ~16% of peak memory on OpenTitan.
    
    2 changes:
    - It is actually safe to delete the substituted expressions immediately,
      but this is the lesser contribution
    - More importantly, we only ever substitute STMTTEMP variables, which
      are always defined within the same CFunc, so we can limit the scope of
      the optimization to CFunc. This allows us to reclaim the SubstVarEntry
      structures at the end of every CFunc, rather than at the end of the
      whole pass, which gives us most of the memory savings.
    
    Generated output is identical
    gezalore authored Nov 12, 2023
    Configuration menu
    Copy the full SHA
    1c0af6c View commit details
    Browse the repository at this point in the history
  11. astgen: Enforce the use of aliased operand accessors (#4688)

    This patch enforces the use of the most specific accessors for operands
    which have an '@Astgen alias' declaration, by making the superclass
    accessors of the same operands private. This ensures client code is
    cleaner as you can't use multiple different methods to reference the
    same operands (which we used to in some places). Also prep for some
    refactoring.
    gezalore authored Nov 12, 2023
    Configuration menu
    Copy the full SHA
    47588f3 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    2882737 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    ee3ba7c View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Configuration menu
    Copy the full SHA
    c8063e5 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Configuration menu
    Copy the full SHA
    9fd5634 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2dba76a View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Fix range access to fields under classes that depend on parameter res…

    …olution (#4681)
    
    Signed-off-by: Krzysztof Boronski <[email protected]>
    kboronski-ant authored Nov 15, 2023
    Configuration menu
    Copy the full SHA
    cc982ec View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Fix dynamic NBAs with automatic vars (#4696)

    This patch addresses two issues with NBAs in non-inlined functions/tasks:
    - If the NBA writes to a local automatic var, the var could cease to exist before the NBA executes. This is normally addressed by fork dynscopes (#4356), but NBA-to-fork transformation happens way after `V3Fork` (in `V3Timing`). To solve this, we put NBAs that write to locals under forks in `V3Fork` already. This way, such locals will be put in dynscopes, and will still exist after the task containing the NBA exits.
    - The above change means that any writes in forks other than `fork..join` should be handled by `V3Fork`. Thus, in `V3SchedTiming`, we only have to worry about read references, so we can simply copy all remaining locals. Because we copy, lifetimes are not an issue. This fixes a bug that allowed assignment intravals to be overwritten if they go out of scope in the containing function.
    kbieganski authored Nov 16, 2023
    Configuration menu
    Copy the full SHA
    b8417ab View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Configuration menu
    Copy the full SHA
    4650105 View commit details
    Browse the repository at this point in the history
  2. Apply 'make format'

    github action committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    ead27db View commit details
    Browse the repository at this point in the history