-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an always_wrap_module_instantiations
flag
#1909
base: master
Are you sure you want to change the base?
Added an always_wrap_module_instantiations
flag
#1909
Conversation
Signed-off-by: Jan Bylicki <[email protected]>
Signed-off-by: Jan Bylicki <[email protected]>
Signed-off-by: Jan Bylicki <[email protected]>
f25c9f4
to
a5216a1
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1909 +/- ##
==========================================
- Coverage 93.13% 92.82% -0.31%
==========================================
Files 355 355
Lines 25843 26132 +289
==========================================
+ Hits 24069 24258 +189
- Misses 1774 1874 +100
☔ View full report in Codecov by Sentry. |
Nice, can you update the Usage section in the README ? (I think at some point we should have a documentation section with examples in the README that demonstrates the result of all flags. For some later PR :) ). |
Signed-off-by: Jan Bylicki <[email protected]>
Co-authored-by: Mariusz Glebocki <[email protected]> Signed-off-by: Jan Bylicki <[email protected]>
e0115e0
to
ea4656f
Compare
Signed-off-by: Jan Bylicki <[email protected]>
ea4656f
to
8f33d2d
Compare
This PR implements a new flag for the formatter:
always_wrap_module_instantiations
.It forces module instantiations to be always split to new lines, instead of fitting it on line wherever possible. The default is set to
false
, which does not change the behavior of the formatter.Fixes #1889
In there, the issue author suggested a two-state solution that I chose to implement.