Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deterministic ECC key pair gen KAT #1655

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Deterministic ECC key pair gen KAT #1655

wants to merge 2 commits into from

Conversation

nquarton
Copy link
Contributor

No description provided.

@nquarton nquarton changed the title Deterministic ecc key pair gen kat Deterministic ECC key pair gen KET Aug 29, 2024
@nquarton nquarton changed the title Deterministic ECC key pair gen KET Deterministic ECC key pair gen KAT Aug 29, 2024
nquarton
nquarton commented Aug 29, 2024
View reviewed changes
kat/src/ecc384_kat.rs Outdated Show resolved Hide resolved
@nquarton nquarton force-pushed the deterministic_ecc_key_pair_gen_kat branch from ea651ef to dea6868 Compare September 19, 2024 15:29
@nquarton nquarton marked this pull request as ready for review September 19, 2024 15:30
swenson
swenson previously approved these changes Sep 23, 2024
View reviewed changes
Copy link

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kat/src/ecc384_kat.rs Show resolved Hide resolved
@nquarton nquarton force-pushed the deterministic_ecc_key_pair_gen_kat branch from dea6868 to c3e9f9e Compare September 23, 2024 18:55
swenson
swenson previously approved these changes Sep 23, 2024
View reviewed changes
kat/src/ecc384_kat.rs Outdated Show resolved Hide resolved
@nquarton nquarton force-pushed the deterministic_ecc_key_pair_gen_kat branch from c3e9f9e to 1deda5b Compare September 24, 2024 16:23
swenson
swenson previously approved these changes Sep 24, 2024
View reviewed changes
Copy link

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment suggestion.

error/src/lib.rs Outdated Show resolved Hide resolved
@nquarton nquarton linked an issue Sep 24, 2024 that may be closed by this pull request
KAT needed for ECC deterministic key pair generation #1653
Open
@nquarton nquarton force-pushed the deterministic_ecc_key_pair_gen_kat branch from 1deda5b to edc91e8 Compare October 8, 2024 17:28
@nquarton nquarton added bug Something isn't working ROM Issue affects ROM FIPS Related to FIPS requirements Run-Time Run-time FW labels Oct 8, 2024
swenson
swenson previously approved these changes Oct 8, 2024
View reviewed changes
mhatrevi
mhatrevi previously approved these changes Oct 10, 2024
View reviewed changes
drivers/src/ecc384.rs Outdated Show resolved Hide resolved
error/src/lib.rs Outdated Show resolved Hide resolved
@nquarton nquarton force-pushed the deterministic_ecc_key_pair_gen_kat branch from edc91e8 to a587272 Compare October 11, 2024 15:47
@JohnTraverAmd JohnTraverAmd enabled auto-merge (squash) October 11, 2024 15:48
@nquarton nquarton dismissed stale reviews from mhatrevi and swenson via 6cefe4b October 11, 2024 21:33
@nquarton nquarton force-pushed the deterministic_ecc_key_pair_gen_kat branch from a587272 to 6cefe4b Compare October 11, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swenson swenson swenson left review comments

@mhatrevi mhatrevi mhatrevi left review comments

@ajisaxena ajisaxena Awaiting requested review from ajisaxena ajisaxena is a code owner

@vsonims vsonims Awaiting requested review from vsonims vsonims is a code owner

@korran korran Awaiting requested review from korran korran is a code owner

@JohnTraverAmd JohnTraverAmd Awaiting requested review from JohnTraverAmd JohnTraverAmd is a code owner

@rusty1968 rusty1968 Awaiting requested review from rusty1968 rusty1968 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working FIPS Related to FIPS requirements ROM Issue affects ROM Run-Time Run-time FW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KAT needed for ECC deterministic key pair generation
3 participants
@nquarton @swenson @mhatrevi