Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-tools: Add rtool subcommand to download artifact #1643

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci-tools: Add rtool subcommand to download artifact #1643

wants to merge 1 commit into from

Conversation

korran
Copy link
Collaborator

@korran korran commented Aug 17, 2024

This is useful to keep the runner images up-to-date.

swenson
swenson previously approved these changes Aug 19, 2024
View reviewed changes
Copy link

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; a minor nit and cleanup suggestion (but I understand that converting to flag is probably out of scope for htis PR).

ci-tools/github-runner/cmd/rtool/main.go Show resolved Hide resolved
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 13, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: korran / name: Kor Nielsen (3f3ab70)

@korran
ci-tools: Add rtool subcommand to download artifact
3f3ab70 
This is useful to keep the runner images up-to-date.
@korran korran requested a review from swenson September 13, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swenson swenson Awaiting requested review from swenson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korran @swenson