[fuse_ctrl,dv] Slightly tidy up some tests about the Caliptra "secret" addresses #740
+34
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expected mask in `wait_dai_op_idle` now masks all partition errors. The error mask within `wait_dai_op_idle` now masks only partition errors and nothing else.
Fix to the address bounds in the partition and to the expected error sent to `wait_dai_op_idle()`
|
Hmm: I'm not convinced that CI is going to work here, because it seems to depend on PRs being made from branches within the same repository. If that's true, I'll wait for access to the ChipsAlliance organisation, sign a CLA and then push a new version of this PR. |
rswarbrick
force-pushed
the
lowrisc-fuse-secret-addr-tidyup
branch
from
923ffe4 to
c60b2b1
Compare
No functional change (but hopefully it makes things a bit clearer: I found these ranges a bit hard to reason about).
The value in caliptra_ss_fuse_ctrl_manuf_prod_prov hadn't yet been updated for the change in 275521b. This change should make it so that test and also caliptra_ss_fuse_ctrl_init_fail get a magic number from a single (documented) place.
rswarbrick
force-pushed
the
lowrisc-fuse-secret-addr-tidyup
branch
from
c60b2b1 to
fe3e952
Compare
ekarabu
reviewed
Sep 19, 2025
|
|
||
| bool is_caliptra_secret_addr(uint32_t addr) { | ||
| // This mirrors CALIPTRA_SECRET_ACCESS_LOWER_ADDR and CALIPTRA_SECRET_ACCESS_UPPER_ADDR in otp_ctrl_pkg | ||
| return addr >= 0x48 && addr <= 0xf0; |
There was a problem hiding this comment.
use *mmap.h file as @antmarzam did in his PR #727
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #727 (which is reproduced here as the first two commits). Merge that first.
After that, the first commit is me documenting exactly what the upper bounds meant (their inclusive nature isn't completely standard, so it's probably worth writing it down). The second commit is tidying up the "is this a secret address?" test so that the magic numbers can be written in a single place.