Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude additional lints in GetCertificateChain and support multiple error codes #349

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

mmiranda96
Copy link
Contributor

What does this PR do?

Fix some tests:

  • GetCertificateChain:
    • Add w_distribution_point_missing_ldap_or_uri and w_ext_aia_access_location_missing to the certificate linter exclusions.
  • InitializeContext:
    • Support both StatusArgumentNotSupported and StatusInvalidArgument when attempting to reinitialize context: if a DPE implementation doesn't support a given command, it makes sense that it returns invalid (it doesn't know it since it doesn't implement it).
    • Change some failures from Fatal to Error, so all required tests run.

@jhand2 jhand2 merged commit 2e02db5 into chipsalliance:main Aug 29, 2024
1 check passed
@mmiranda96 mmiranda96 deleted the fix/test-linter-cleanup branch August 30, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants