Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OCTET STRING in authorityKeyIdentifier IMPLICIT #346

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

jlmahowa-amd
Copy link
Contributor

No description provided.

@ekoohest
Copy link

ekoohest commented Jun 17, 2024

Hi @jlmahowa-amd , unit tests are failing in CI/ CD. Would you help to fixing them?

failures:

---- commands::certify_key::tests::test_is_ca stdout ----
thread 'commands::certify_key::tests::test_is_ca' panicked at 'assertion failed: (left == right)
left: [52, 106, 4, 135, 89, 105, 47, 57, 167, 64, 73, 244, 240, 127, 198, 251, 178, 203],
right: [245, 209, 52, 106, 4, 135, 89, 105, 47, 57, 167, 64, 73, 244, 240, 127, 198, 251, 178, 203]', dpe/src/commands/certify_key.rs:462:29
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

---- x509::tests::test_full_ca stdout ----
thread 'x509::tests::test_full_ca' panicked at 'assertion failed: (left == right)
left: [236, 80, 187, 238, 98, 157, 180, 93, 255, 239, 104, 155, 145, 75, 38, 216, 23, 37],
right: [230, 46, 236, 80, 187, 238, 98, 157, 180, 93, 255, 239, 104, 155, 145, 75, 38, 216, 23, 37]', dpe/src/x509.rs:2777:21

@jlmahowa-amd jlmahowa-amd force-pushed the jlmahowa/authority_key_identifier branch from 6be59f4 to ef89c80 Compare June 19, 2024 15:59
@jhand2
Copy link
Collaborator

jhand2 commented Jun 20, 2024

Thanks!

@jhand2 jhand2 merged commit f06e88c into main Jun 20, 2024
1 check passed
@jlmahowa-amd jlmahowa-amd deleted the jlmahowa/authority_key_identifier branch June 21, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPE Leaf certificate authority key identifier formatting incorrect
3 participants