Add CFI to DPE

[sree-revoori1]

No description provided.

[jhand2]

Let me know if I'm misunderstanding, but a general comment is it seems like the CFI codepaths may not really be tested here, since I don't think we implement cfi_panic_handler anywhere in this repo. So any issues with final linking or something like that will only be caught once this is built into caliptra-sw.

But this PR is already fairly large, so maybe we should just open an issue for how to better test this inside of caliptra-dpe.

[sree-revoori1]

Let me know if I'm misunderstanding, but a general comment is it seems like the CFI codepaths may not really be tested here, since I don't think we implement cfi_panic_handler anywhere in this repo. So any issues with final linking or something like that will only be caught once this is built into caliptra-sw.

But this PR is already fairly large, so maybe we should just open an issue for how to better test this inside of caliptra-dpe.

We are testing it since I added the dev-dependency caliptra-cfi-lib with the cfi-test feature. caliptra-cfi has a cfi_panic_handler and cfi_state for testing purposes behind the cfi-test feature. I confirmed that CFI codepaths are being hit in the CI too.

[jhand2]

Let me know if I'm misunderstanding, but a general comment is it seems like the CFI codepaths may not really be tested here, since I don't think we implement cfi_panic_handler anywhere in this repo. So any issues with final linking or something like that will only be caught once this is built into caliptra-sw.
But this PR is already fairly large, so maybe we should just open an issue for how to better test this inside of caliptra-dpe.

We are testing it since I added the dev-dependency caliptra-cfi-lib with the cfi-test feature. caliptra-cfi has a cfi_panic_handler and cfi_state for testing purposes behind the cfi-test feature. I confirmed that CFI codepaths are being hit in the CI too.

Oh cool, thanks!