Merge branch 'chipsalliance:main' into derivechild_support

simulator/README.md

@@ -1,6 +1,6 @@
 # DPE Simulator
 
-The DPE simulator is a userspace simulator which serves as a DPE intance.
+The DPE simulator is a userspace simulator which serves as a DPE instance.
 
 ## Transport
 

verification/certifyKey.go

@@ -49,7 +49,7 @@ type TcgUeidExtension struct {
 	Ueid []uint8 `asn1:"ueid,implicit"`
 }
 
-// Fwid represents a TCG DICE FWID stucture
+// Fwid represents a TCG DICE FWID structure
 type Fwid struct {
 	HashAlg asn1.ObjectIdentifier
 	Digest  []byte
@@ -114,7 +114,7 @@ const (
 // TcgMultiTcbInfo represents a sequence of TCBInfos
 type TcgMultiTcbInfo = []DiceTcbInfo
 
-// CertifyKeyParams holds configurable paramters to CertifyKey for test-cases
+// CertifyKeyParams holds configurable parameters to CertifyKey for test-cases
 type CertifyKeyParams struct {
 	Label []byte
 	Flags CertifyKeyFlags
@@ -208,7 +208,7 @@ func TestCertifyKeyCsr(d TestDPEInstance, c DPEClient, t *testing.T) {
 }
 
 // Ignores critical extensions that are unknown to x509 package
-// but atleast defined in DPE certificate profile specification.
+// but at least defined in DPE certificate profile specification.
 // UnhandledCriticalExtensions may have only custom extensions mentioned in spec
 // unknownExtnMap collects extensions unknown to both x509 and the DICE certificate profiles spec.
 // positive case expects the unknownExtnMap to be empty.
@@ -241,7 +241,7 @@ func removeTcgDiceCriticalExtensions(t *testing.T, certs []*x509.Certificate) {
 }
 
 // Ignores extended key usages that are unknown to x509 package
-// but atleast defined in DPE certificate profile specification.
+// but at least defined in DPE certificate profile specification.
 // UnhandledExtendedKeyUsages may have only custom key usages mentioned in spec
 // unknownKeyUsagesMap collects keyusages unknown to both x509 and the DICE certificate profiles spec.
 // positive case expects the unknownKeyUsagesMap to be empty.

verification/certs.go

@@ -162,7 +162,7 @@ func getTcbInfoForHandle(c DPEClient, handle *ContextHandle) (*ContextHandle, Di
 	}
 
 	if len(multiTcbInfo) == 0 {
-		return outHandle, DiceTcbInfo{}, fmt.Errorf("Certificate MutliTcbInfo is empty")
+		return outHandle, DiceTcbInfo{}, fmt.Errorf("Certificate MultiTcbInfo is empty")
 	}
 
 	return outHandle, multiTcbInfo[0], nil

verification/getCertificateChain.go

@@ -122,7 +122,7 @@ func validateCertChain(t *testing.T, certChain []*x509.Certificate) {
 			t.Errorf("[ERROR]: Error in Certificate Chain of %s: %s", cert.Subject, err.Error())
 		}
 
-		// Log certificate chains linked to each cetificate in chain
+		// Log certificate chains linked to each certificate in chain
 		if len(chains) != 1 {
 			t.Errorf("[ERROR]: validateCertChain certificate chain is empty")
 		}

verification/negativeCases.go

@@ -167,7 +167,7 @@ func TestUnsupportedCommand(d TestDPEInstance, c DPEClient, t *testing.T) {
 // command flags that are turned off in DPE.
 // The DPE command may be available but some of its flags may not be supported by DPE.
 // DPE profile supports the below attributes.
-// Simulation	: Allows caller to request for context iniitialization in simulation mode
+// Simulation	: Allows caller to request for context initialization in simulation mode
 // IsCA			: Allows caller to request the key cert of CA
 // Csr 			: Allows caller to request the key cert in CSR format
 // X509 		: Allows caller to request the key cert in X509 format

verification/simulator.go

@@ -179,7 +179,7 @@ func (s *DpeSimulator) GetSupportedLocalities() []uint32 {
 	return []uint32{DPESimulatorAutoInitLocality, DPESimulatorOtherLocality}
 }
 
-// HasLocalityControl returns whehter the simulator can artificially set the
+// HasLocalityControl returns whether the simulator can artificially set the
 // locality of the caller. The simulator target can always control the locality.
 func (s *DpeSimulator) HasLocalityControl() bool {
 	return true

verification/verification.go

@@ -1,5 +1,10 @@
 // Licensed under the Apache-2.0 license
 
+// Package verification provides verification tests for implementations of the DPE iRoT profile.
+//
+// This packages also includes a modular DPE client that can be used to
+// communicate with DPE over different transports. A transport for the DPE
+// rust simulator is provided in this package.
 package verification
 
 import (
@@ -86,7 +91,7 @@ var UnsupportedCommand = TestCase{
 
 // UnsupportedCommandFlag tests calling unsupported commands flags
 var UnsupportedCommandFlag = TestCase{
-	"CheckSupportForCommmandFlag", TestUnsupportedCommandFlag, []string{"AutoInit", "RotateContext", "ExtendTci"},
+	"CheckSupportForCommandFlag", TestUnsupportedCommandFlag, []string{"AutoInit", "RotateContext", "ExtendTci"},
 }
 
 // RotateContextTestCase tests RotateContext