Fix encoding of SubjectKeyIdentifier

Subject key identifier is implicit, not explicit.
chipsalliance · Jan 31, 2024 · 01128ac · 01128ac
1 parent c1be779
commit 01128ac
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/dpe/src/x509.rs b/dpe/src/x509.rs
@@ -1552,9 +1552,8 @@ impl CertWriter<'_> {
         &mut self,
         subject_key_identifier: &[u8],
     ) -> Result<usize, DpeErrorCode> {
-        // SubjectKeyIdentifier is EXPLICIT field number 0
-        let mut bytes_written =
-            self.encode_byte(Self::CONTEXT_SPECIFIC | Self::CONSTRUCTED | 0x0)?;
+        // SubjectKeyIdentifier is IMPLICIT field number 0
+        let mut bytes_written = self.encode_byte(Self::CONTEXT_SPECIFIC | 0x0)?;
         bytes_written += self.encode_size_field(Self::get_subject_key_identifier_size(
             subject_key_identifier,
             /*tagged=*/ true,