Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make utility executables exit with error code 0 when running --help #1001

Merged
merged 1 commit into from
Aug 14, 2023
Merged

make utility executables exit with error code 0 when running --help #1001

merged 1 commit into from
Aug 14, 2023

Conversation

timkpaine
Copy link
Collaborator

@timkpaine timkpaine commented Aug 14, 2023

It can be difficult to determine that all linking has been done correctly in a build environment by just looking at the generated libraries. A common pattern I've been seeing (e.g. on homebrew, conda, etc) is to run my-executable --help which seems to be expected to not have an error exit code. A quick survey of CLIs on my box confirms this pattern >50% of the time, so I propose we use it here. This is also the behavior of the surelog command.

@alaindargelas alaindargelas merged commit 955290e into chipsalliance:master Aug 14, 2023
6 checks passed
@timkpaine timkpaine deleted the tkp/exitcode branch August 14, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants