Merge pull request #1046 from alainmarcel/alainmarcel-patch-1

pos int check
chipsalliance · Oct 19, 2023 · c42e783 · c42e783
2 parents 7e9ae0f + 815213d
commit c42e783
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 1 deletion.
diff --git a/templates/Serializer.h b/templates/Serializer.h
@@ -64,7 +64,8 @@ enum ErrorType {
   UHDM_INVALID_CASE_STMT_VALUE = 727,
   UHDM_UNSUPPORTED_TYPESPEC = 728,
   UHDM_UNRESOLVED_PROPERTY = 729,
-  UHDM_NON_TEMPORAL_SEQUENCE_USE = 730
+  UHDM_NON_TEMPORAL_SEQUENCE_USE = 730,
+  UHDM_NON_POSITIVE_VALUE = 731
 };
 
 #ifndef SWIG

diff --git a/templates/UhdmLint.cpp b/templates/UhdmLint.cpp
@@ -314,4 +314,27 @@ void UhdmLint::leaveProperty_spec(const property_spec* prop_s,
   }
 }
 
+void UhdmLint::leaveSys_func_call(const sys_func_call* object,
+                                  vpiHandle handle) {
+  ExprEval eval;
+  eval.setDesign(design_);
+  if (object->VpiName() == "$past") {
+    if (auto arg = object->Tf_call_args()) {
+      if (arg->size() == 2) {
+        any* ex = arg->at(1);
+        bool invalidValue = false;
+        const int64_t val = eval.get_value(
+            invalidValue,
+            eval.reduceExpr(ex, invalidValue, nullptr, object->VpiParent()));
+        if (val <= 0 && (invalidValue == false)) {
+          const std::string errMsg = std::to_string(val);
+          serializer_->GetErrorHandler()(
+              ErrorType::UHDM_NON_POSITIVE_VALUE, errMsg,
+              ex, nullptr);
+        }
+      }
+    }
+  }
+}
+
 }  // namespace UHDM
diff --git a/templates/UhdmLint.h b/templates/UhdmLint.h
@@ -55,6 +55,8 @@ class UhdmLint final : public VpiListener {
   void leaveProperty_spec(const property_spec* object,
                           vpiHandle handle) override;
 
+  void leaveSys_func_call(const sys_func_call* object, vpiHandle handle) override;
+
   void checkMultiContAssign(const std::vector<UHDM::cont_assign*>* assigns);
 
   Serializer* serializer_ = nullptr;

diff --git a/util/uhdm-lint.cpp b/util/uhdm-lint.cpp
@@ -169,6 +169,9 @@ int32_t main(int32_t argc, char **argv) {
           case UHDM::UHDM_NON_TEMPORAL_SEQUENCE_USE:
             errmsg = "Sequence used in non-temporal context";
             break;
+          case UHDM::UHDM_NON_POSITIVE_VALUE:
+            errmsg = "Non positive (<1) value";
+            break;
         }
 
         if (object1) {