fix(examples): prevent duplicate content on window resize #1580
Open
VaibhavVermaa16 wants to merge 1 commit intocharmbracelet:mainfrom
Open
fix(examples): prevent duplicate content on window resize #1580VaibhavVermaa16 wants to merge 1 commit intocharmbracelet:mainfrom
VaibhavVermaa16 wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
…mple Fixes content duplication issue when terminal window is resized by handling WindowSizeMsg before passing to child components. Previously, both the viewport and textarea processed resize events independently, causing viewport state to become inconsistent with rendered content. Fixes charmbracelet#1567
VaibhavVermaa16
requested review from
aymanbagabas and
meowgorithm
as code owners
Member
|
Hi @VaibhavVermaa16, thank you for fixing this issue. Could you please backport this to the |
Author
|
Done, I've backported this fix to v2-exp branch and opened a new PR: #1581 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes content duplication issue when terminal window is resized by handling WindowSizeMsg before passing to child components. Previously, both the viewport and textarea processed resize events independently, causing viewport state to become inconsistent with rendered content.
Fixes #1567
CONTRIBUTING.md.