feat: allow chainable msg filters; add MouseThrottleFilter#1544
Open
lrstanley wants to merge 1 commit intocharmbracelet:v2-expfrom
Open
feat: allow chainable msg filters; add MouseThrottleFilter#1544lrstanley wants to merge 1 commit intocharmbracelet:v2-expfrom
lrstanley wants to merge 1 commit intocharmbracelet:v2-expfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2-exp #1544 +/- ##
==========================================
- Coverage 57.28% 56.26% -1.03%
==========================================
Files 25 25
Lines 1201 1221 +20
==========================================
- Hits 688 687 -1
- Misses 436 455 +19
- Partials 77 79 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Liam Stanley <liam@liam.sh>
lrstanley
force-pushed
the
feature/chainable-filters
branch
from
04404fd to
59d353c
Compare
Contributor
Author
|
Tests currently breaking due to Line 7 in f60735d |
Member
I removed this in the latest v2-exp commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this PR
Made some tweaks to message filtering, as I think this will help others. If y'all don't think it will be too useful, or would rather approach it a different way, feel free to close this out.
WithFilter(filter)toWithFilters(filters...)to allow chainable filters, with aMsgFiltertype to clean things up a little.MouseThrottleFilterfilter, to cover throttling of high-frequency mouse messages. This logic is also used in crush here, and one of my apps, and I suspect such functionality will help others improve performance when they don't need the high-frequency tracking.CONTRIBUTING.md.