Conversation
Signed-off-by: João Gonçalves <jsvgoncalves@gmail.com>
* Creating the concepts needs to be decouple from creating the concept_schemes, as concepts might need to be added to existing concept_schemes. Signed-off-by: João Gonçalves <jsvgoncalves@gmail.com>
|
|
||
| # Configuration | ||
| API_URL = "http://localhost:8000" | ||
| API_TOKEN = "missing" |
There was a problem hiding this comment.
Using a hard-coded API token may lead to security issues; consider retrieving the token from an environment variable instead.
Suggested change
| API_TOKEN = "missing" | |
| import os | |
| API_TOKEN = os.getenv("API_TOKEN", "missing") |
| await create_schemes() | ||
|
|
||
| if args.concepts: | ||
| if not args.scheme_id: |
There was a problem hiding this comment.
When '--scheme-id' is missing while creating concepts, consider exiting with a non-zero status code (e.g., using sys.exit(1)) rather than only printing an error message, to properly signal the failure.
Contributor
|
Not needed now as we have useful data but maybe useful in the future... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving over from cauldron/py-semantic-taxonomy#45