Closed
Conversation
Signed-off-by: João Gonçalves <jsvgoncalves@gmail.com>
* Creating the concepts needs to be decouple from creating the concept_schemes, as concepts might need to be added to existing concept_schemes. Signed-off-by: João Gonçalves <jsvgoncalves@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new script that generates basic sample data for a semantic taxonomy by creating concept schemes and associated concepts using asynchronous API calls. Key changes include:
- Implementation of functions to create multilingual strings, concept schemes, and concepts.
- Integration with the pyst_client API for creating sample taxonomy data.
- Command-line interface support for generating schemes, concepts, or both.
Comments suppressed due to low confidence (2)
scripts/create_sample_data.py:201
- Consider using argparse.error() or sys.exit() to handle the missing '--scheme-id' scenario, ensuring that the error is clearly communicated and the program exits with a non-zero status.
print("Error: --scheme-id is required when creating concepts")
scripts/create_sample_data.py:22
- [nitpick] The function name 'create_multilingual_string' suggests a single string, but it returns a list; consider renaming it to 'create_multilingual_strings' for improved clarity.
def create_multilingual_string(text_base: str, index: int) -> List[MultilingualString]:
Contributor
|
Thanks @jsvgoncalves - feels like this should be a part of the If you agree I can move it over. |
Member
Author
|
@cmutel just cherry-picked the commits to the other repo, PR at cauldron/pyst-client#2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.